feat: new schema version with addition to specify contianer build network for buildpack #9745
+7,317
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdannazarenko
force-pushed
the
buildpack-docker-network
branch
from
b505750 to
e2be8b7
Compare
bogdannazarenko
force-pushed
the
buildpack-docker-network
branch
from
e2be8b7 to
27840b2
Compare
bogdannazarenko
force-pushed
the
buildpack-docker-network
branch
from
27840b2 to
1b289df
Compare
|
@Darien-Lin @katiexzhang @menahyouyeah I generate a new schema version and added by schema changes for the buildpack build |
bogdannazarenko
changed the title
|
Would it be possible to split this into 2 commits - one with all the schema related changes and another with the logic changes to make it easier to review? |
| // Volumes support mounting host volumes into the container. | ||
| Volumes []*BuildpackVolume `yaml:"volumes,omitempty"` | ||
|
|
||
| // Network is the network to use for the build. |
There was a problem hiding this comment.
Instead of adding just the Network arg can you do something similar to #9696. Basically a BuildArgs []string or something along those lines so that in the future if people wanted to pass additional args there wouldn't need to be any additional logic or schema change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9744
Related: N/A
Merge before/after: N/A
Description
Adding schema property
networkfor buildpack image builds to specify custom container build network. See linked issue description and use case.User facing changes (remove if N/A)
Addition property available to set on buildpack image build configurations.