Import ARW files as Images #2106
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbertronnie
force-pushed
the
add-raw-image-in-editor
branch
from
8b938a2 to
f4a1042
Compare
elbertronnie
force-pushed
the
add-raw-image-in-editor
branch
from
f4a1042 to
3007fb6
Compare
|
Just for context, this is currently stalled due to #1895 (duplicate of #1231). The uncompressed RAW images use a lot of memory. We also appear to clone them a lot (e.g. when running the node graph and running autosave). This exceeds the WASM memory limits leading to a crash whenever you attempt to work with a RAW file. |
|
And specifically #1604. |
|
@Keavon Seeing as this code is perfectly fine, I think we should merge this. |
|
@0HyperCube I doubt that merging this will be useful. This PR only works on very small RAW images which do not exist and after the asset database, this entire PR will need to rewritten anyway. |
Keavon
force-pushed
the
master
branch
2 times, most recently
from
7465fad to
ab724d8
Compare
Keavon
force-pushed
the
master
branch
4 times, most recently
from
aa7ff13 to
e11b57a
Compare
Keavon
force-pushed
the
master
branch
3 times, most recently
from
c7488cf to
1875779
Compare
Keavon
force-pushed
the
master
branch
4 times, most recently
from
ec51271 to
e025103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked because of #1895, waiting on #1604 to be unblocked. Closes #2188