Skip to content

Bezier-rs: Make rectangle constructor produce linear segments #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

Bezier-rs: Make rectangle constructor produce linear segments #2109

merged 2 commits into from
Nov 18, 2024

Conversation

@Sidharth-Singh10
Copy link
Contributor

@Sidharth-Singh10 Sidharth-Singh10 commented Nov 14, 2024

Closes #1696

new_rec constructor now should create linear segments instead of cubic segments.

@Sidharth-Singh10 Sidharth-Singh10 marked this pull request as ready for review November 15, 2024 10:29
@Keavon
Copy link
Member

Keavon commented Nov 18, 2024

!build

@Keavon Keavon changed the title fix(bezier-rs): new_rect constructor create linear segments Bezier-rs: Make rectangle constructor produce linear segments Nov 18, 2024
@github-actions
Copy link

github-actions bot commented Nov 18, 2024

📦 Build Complete for 2c94948
https://224f499b.graphite.pages.dev

Keavon
Keavon approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@Keavon Keavon enabled auto-merge (squash) November 18, 2024 21:06
@Keavon Keavon merged commit 3b503cc into GraphiteEditor:master Nov 18, 2024
4 checks passed
@Sidharth-Singh10 Sidharth-Singh10 mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keavon Keavon Keavon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subpath::new_rect() creates cubic segments instead of linear segments

2 participants

@Sidharth-Singh10 @Keavon