Fix SVG viewBox capitalization in renderer
#2131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TIL that would be case sensitive in some contexts! Thanks for this. |
Keavon
changed the title
viewBox capitalizationviewBox capitalization in renderer
0HyperCube
approved these changes
Dec 7, 2024
0SlowPoke0
pushed a commit
to 0SlowPoke0/Graphite
that referenced
this pull request
Dec 17, 2024
fix `viewBox` capitalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check issue #2130 for description.
The
viewBoxattribute was erroneously lowercase, but the spec and browser rendering need it to be "viewBox".Closes #2130