Desktop: Fix maximized window extending outside the screen on Windows #3210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timon-schelling
force-pushed
the
desktop-fix-window-extending-outside-the-screen-windows
branch
from
f94ed99 to
5cea64e
Compare
Keavon
changed the title
|
I don't think I'm the best person to test this but I guess the code looks fine |
It was tested on Windows by keavon. |
TrueDoctor
approved these changes
Sep 25, 2025
timon-schelling
deleted the
desktop-fix-window-extending-outside-the-screen-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3191
We should discuss if this closes it.
On small issue remaining, due to using a custom window frame winit::Window::is_maximized always returns false on win32 and we cant update the icon correctly because maximizing looks like resizing to winit.Mostly a issue on vms without GPU.There are workarounds, but my preferred solution would be to introduce a WindowHandle type that holds both the window and native window handle and would have working implementations on all platforms for things like is_maximized (could depending on platform use native window handle or window to determine maximized state etc.).
That will need some work though and I would prefer merging this PR before the event on the 26th.