Restructure gcore/text module and fix memory leak #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueDoctor
force-pushed
the
fix-text-leak
branch
from
1ccbef3 to
51d3c6f
Compare
TrueDoctor
force-pushed
the
fix-text-leak
branch
from
0fcf297 to
5e106cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr I restructure the thread local state for font shaping by combining the
FontContextLayoutContextand a hash map for reusing already registered fonts. We now implement most functions directly on this struct and provide wrapper methods to still expose a simple api.I did also break out the font -> bezpath conversion into its own file to reduce the conceptual scope of the files so the large diff is mostly code movement