Skip to content

Make new document with doubleclicking on empty tab space #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+273 −5
Open

Make new document with doubleclicking on empty tab space #3228

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2bd0789
Make new document with doubleclicking on empty tab space
partg952 Sep 26, 2025
866749f
fixed linting error
partg952 Sep 26, 2025
b5835bb
added another LayoutRow and added the double click event to that cont…
partg952 Sep 29, 2025
9867930
added another LayoutRow and added the double click event to that cont…
partg952 Sep 29, 2025
0ce356b
Merge branch 'GraphiteEditor:master' into master
partg952 Sep 29, 2025
63c734c
Merge branch 'master' into master
partg952 Oct 2, 2025
cf08916
Merge branch 'GraphiteEditor:master' into master
partg952 Oct 4, 2025
f834eb5
passed the double click function as a prop
partg952 Oct 4, 2025
adde82e
removed debug changes
partg952 Oct 4, 2025
a3feae2
Merge branch 'master' into master
partg952 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions editor/src/messages/tool/tool_messages/pen_tool.rs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove theses debug changes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've committed more things by accident. In the future before you ping with comment please check yourself if the changes in the File Changes tab of the pr only include what you what to be part of the pr.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry , the pr got quite messy I will make sure of it in the coming pull requests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. :)

Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,7 @@ impl PenToolData {
let document = snap_data.document;
let next_handle_start = self.next_handle_start;
let handle_start = self.latest_point()?.handle_start;

let mouse = snap_data.input.mouse.position;
self.handle_swapped = false;
self.handle_end_offset = None;
Expand Down
14 changes: 11 additions & 3 deletions frontend/src/components/window/workspace/Panel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@
</script>

<LayoutCol on:pointerdown={() => panelType && editor.handle.setActivePanel(panelType)} class={`panel ${className}`.trim()} {classes} style={styleName} {styles}>
<LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }}>
<LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }} >

<LayoutRow class="tab-group" scrollableX={true}>
{#each tabLabels as tabLabel, tabIndex}
<LayoutRow
Expand Down Expand Up @@ -148,11 +149,16 @@
{/if}
</LayoutRow>
{/each}
{#if panelType == 'Document'}
<LayoutRow class="tab-group-empty-space" on:dblclick={() => editor.handle.newDocumentDialog()}></LayoutRow>
{/if}
</LayoutRow>

<!-- <PopoverButton style="VerticalEllipsis">
<TextLabel bold={true}>Panel Options</TextLabel>
<TextLabel multiline={true}>Coming soon</TextLabel>
</PopoverButton> -->

</LayoutRow>
<LayoutCol class="panel-body">
{#if panelType}
Expand Down Expand Up @@ -218,13 +224,15 @@
background: var(--color-1-nearblack);
border-radius: 6px;
overflow: hidden;
.tab-bar {
height: 28px;
min-height: auto;
background: var(--color-1-nearblack); // Needed for the viewport hole punch on desktop
flex-shrink: 0;
.tab-group-empty-space {
width: 100%;
}
&.min-widths .tab-group .tab {
min-width: 120px;
max-width: 360px;
Expand Down