Skip to content

Make new document with doubleclicking on empty tab space #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+273 −5
Open

Make new document with doubleclicking on empty tab space #3228

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2bd0789
Make new document with doubleclicking on empty tab space
partg952 Sep 26, 2025
866749f
fixed linting error
partg952 Sep 26, 2025
b5835bb
added another LayoutRow and added the double click event to that cont…
partg952 Sep 29, 2025
9867930
added another LayoutRow and added the double click event to that cont…
partg952 Sep 29, 2025
0ce356b
Merge branch 'GraphiteEditor:master' into master
partg952 Sep 29, 2025
63c734c
Merge branch 'master' into master
partg952 Oct 2, 2025
cf08916
Merge branch 'GraphiteEditor:master' into master
partg952 Oct 4, 2025
f834eb5
passed the double click function as a prop
partg952 Oct 4, 2025
adde82e
removed debug changes
partg952 Oct 4, 2025
a3feae2
Merge branch 'master' into master
partg952 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/components/window/workspace/Panel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
</script>

<LayoutCol on:pointerdown={() => panelType && editor.handle.setActivePanel(panelType)} class={`panel ${className}`.trim()} {classes} style={styleName} {styles}>
<LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }}>
<LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }} on:dblclick={() => editor.handle.newDocumentDialog()}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add the click handler to a new element that fills the portion of the bar not occupied by tabs, you won’t need to stop event propagation. I think it feels a little cleaner.

Copy link
Author

@partg952 partg952 Sep 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain a little more?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its about making 2 new LayoutCol. Left one should have contain existing document tab and the right one could have on:dblclick=()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain a little more?

I mean add a extra child to the tab bar at the end that takes all remaining space.
That child would have the dblclick listener.

Take a look at how I did it in a similar case

Graphite/frontend/src/components/window/title-bar/TitleBar.svelte

Line 79 in bc66148

<LayoutRow on:mousedown={() => editor.handle.appWindowDrag()} on:dblclick={() => editor.handle.appWindowMaximize()} />

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh okay lemme do it like that

<LayoutRow class="tab-group" scrollableX={true}>
{#each tabLabels as tabLabel, tabIndex}
<LayoutRow
Expand All @@ -118,6 +118,7 @@
closeAction?.(tabIndex);
}
}}
on:dblclick={(e) => e.stopPropagation()}
on:mouseup={(e) => {
// Middle mouse button click fallback for Safari:
// https://developer.mozilla.org/en-US/docs/Web/API/Element/auxclick_event#browser_compatibility
Expand Down
Loading