Reduce Nix flake maintanace by eliminating need for cargoHash bumps
#3292
+57
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should picomatch be a dev dependency? Please also explain its purpose and justification for usage so I can double check its necessity and authorize the new dependency. |
I have removed picomatch from the dependencies and undone all NPM-related changes I have made. @timon-schelling and I attempted to make the new install strategy work and we just couldn't. The PR is now in a reviewable state. |
|
!build |
|
|
!build |
|
timon-schelling
changed the title
cargoHash bumps
|
!build |
timon-schelling
approved these changes
Oct 18, 2025
|
|
I just noticed that shader (GPU) nodes are not yet enabled. |
|
Merging because this was also the case before this pr. I will create a separate pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all repos in
Cargo.tomlthat use an out-of-tree commit to ones where said commit is in-tree. Additionally, it removes the hash requirement for Nix builds, so the Graphite flake can now use up-to-date versions of Graphite without the need for any CI to update hashes.Progress is being made to do the same for NPM fetching.