Skip to content

Add Inputs state dot badge to System and Inputs menu #23989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 27, 2025
Merged

Add Inputs state dot badge to System and Inputs menu #23989

merged 13 commits into from
Oct 27, 2025

Conversation

@ousmaneo
Copy link
Contributor

Part of #12243

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo marked this pull request as ready for review October 21, 2025 13:44
@ousmaneo ousmaneo requested review from gally47 and laura-b-g October 21, 2025 13:44
gally47
gally47 requested changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one comment below:

graylog2-web-interface/src/components/inputs/InputsDotBadge.tsx Outdated
import styled from 'styled-components';

import useInputsStates from 'hooks/useInputsStates';
const Badge = styled.span`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is already (IlluminateDotBadge) and will probably be used again elsewhere I think we should extract this and create a global reusable DotBadgeTitle component with the props (title and showDotBadge)

@ousmaneo ousmaneo requested a review from gally47 October 22, 2025 07:27
gally47
gally47 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, LGTM, one nitpick below:

graylog2-web-interface/src/components/inputs/InputsDotBadge.tsx Outdated
<MenuItemDotBadge
text={text}
title="Some inputs are in failed state or in setup mode."
showDot={hasFailedOrSetupInputs || false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an || false here?

@ousmaneo ousmaneo merged commit 9075cb3 into master Oct 27, 2025
20 checks passed
@ousmaneo ousmaneo deleted the add-inputs-dot-badge branch October 27, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gally47 gally47 gally47 approved these changes

@laura-b-g laura-b-g Awaiting requested review from laura-b-g

Assignees

No one assigned

Labels

ready-for-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ousmaneo @gally47