Skip to content

Transforms cleanup#887

Open
ZackAttack614 wants to merge 30 commits intomasterfrom
transforms-cleanup
Open

Transforms cleanup#887
ZackAttack614 wants to merge 30 commits intomasterfrom
transforms-cleanup

Conversation

@ZackAttack614
Copy link
Collaborator

Overview

This PR removes a lot of unused and dead code from the transforms module of HEXRD. We aniticpate that this may affect users who have very old scripts (5 years or more) or others who have used the xf or old_xfcapi components of the library. As this code has not been supported in many years, it is time for this code to be removed from the library. We will support the transition to the newer code as needed, on a case-by-case basis.

Some documentation about transitioning from the old_xfcapi code can be found in the Wiki:

https://github.com/HEXRD/hexrd/wiki/old_xfcapi-Conversion-Guide

Affected Workflows

Users who have scripts which use the old_xfcapi or xf components of HEXRD's transforms module will need to move off of this and into the new API, using the conversion guide above.

Documentation Changes

Documentation regarding transition has been written, and uploaded into the Github Wiki. Documentation covering the removed code has been deleted.

@ZackAttack614 ZackAttack614 requested a review from psavery February 4, 2026 20:34
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.22%. Comparing base (94752c7) to head (1452865).
⚠️ Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
hexrd/core/transforms/new_capi/xf_new_capi.py 85.71% 2 Missing ⚠️
hexrd/core/instrument/hedm_instrument.py 0.00% 1 Missing ⚠️
hexrd/core/utils/panel_buffer.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   69.88%   71.22%   +1.34%     
==========================================
  Files         147      142       -5     
  Lines       22324    21637     -687     
==========================================
- Hits        15602    15412     -190     
+ Misses       6722     6225     -497     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant