Skip to content

AB#326 Fix cancellation related bugs on stop page#5663

Merged
vesameskanen merged 2 commits intov3from
AB#326
Feb 19, 2026
Merged

AB#326 Fix cancellation related bugs on stop page#5663
vesameskanen merged 2 commits intov3from
AB#326

Conversation

@hjvuor
Copy link
Contributor

@hjvuor hjvuor commented Feb 19, 2026

Cancelled trips result in some unwanted behavior on stops that are the last stop of some route. The logic is based on the pickupType of the stoptime, but cancelled trips omit this property so the current logic fails.

Proposed Changes

  • On departure list, cancelled trips are now correctly shown with arriving / last stop as the headsign
  • Timetable view correctly filters out arrivals even if they belong to a cancelled trip

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

@vesameskanen vesameskanen merged commit 30a6b04 into v3 Feb 19, 2026
7 checks passed
@vesameskanen vesameskanen deleted the AB#326 branch February 19, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants