Skip to content

Update sass deps#5665

Open
Antiik91 wants to merge 5 commits intonextfrom
update-sass-deps
Open

Update sass deps#5665
Antiik91 wants to merge 5 commits intonextfrom
update-sass-deps

Conversation

@Antiik91
Copy link
Member

Proposed Changes

  • Update sass dependencies
  • Supress warnings for sass deprecations for now.
  • Removed foundation 5

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found only two style errors:

  • Desktop/Route view/Timetable tab/from-to selector styles badly broken
  • Terminal view's header renders 'Asema' label in wrong position (destop and mobile)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants