Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
deanframe
reviewed
Nov 2, 2022
Contributor
deanframe
left a comment
deanframe
left a comment
There was a problem hiding this comment.
Looks good but asked a couple questions
| const confirmedDialogText = screen.getByTestId('dropdown-question'); | ||
|
|
||
| expect(confirmedDialogText.textContent).toContain(exampleContent); | ||
| expect(confirmedDialogText.textContent).toContain("Select"); |
Contributor
There was a problem hiding this comment.
should we also be checking that the correct dropdown options render when it is clicked?
Contributor
There was a problem hiding this comment.
^^ this is a rlly good point!
jzhzhang66
requested changes
Nov 2, 2022
Contributor
jzhzhang66
left a comment
jzhzhang66
left a comment
There was a problem hiding this comment.
Thanks for working on this Surbhi!
+1 to Dean's comment and also could you please add tests in both files for
- when a question is required - there should be the text that says 'this quesiton is required ' or something
- when the question is disabled you shouldn't be able to click anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #189.