-
Notifications
You must be signed in to change notification settings - Fork 3
Rizan ibrahim w3 database #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rizan ibrahim w3 database #22
Conversation
yunchen4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Rizan,
There are some points that you need to rework, especially for the mongodb exercise. Otherwise it looks good.
Please let me know on Slack when you finish the rework, so I can review it again!
| function getPopulation(conn, table, name, code, cb) { | ||
| // assuming that connection to the database is established and stored as conn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rework: I didn't see the answer for the first question in 3.3?
Give an example of a value that can be passed as name and code that would take advantage of SQL-injection and ( fetch all the records in the database)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still didn't see the answer for this question?
| await connection.execute( | ||
| ` | ||
| insert into account_changes (account_no,amount,change_date,remark) | ||
| values (?,?,now(),?)`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to use NOW() here 👍
yunchen4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Rizan,
Nice work done on the mongodb exercises. But I still didn't see the answer for SQL injection question 1?
yunchen4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.