Skip to content

Conversation

@rizan-ibrahim
Copy link

No description provided.

@yunchen4 yunchen4 self-assigned this Jun 6, 2025
Copy link

@yunchen4 yunchen4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Rizan,
There are some points that you need to rework, especially for the mongodb exercise. Otherwise it looks good.
Please let me know on Slack when you finish the rework, so I can review it again!

Comment on lines +1 to +2
function getPopulation(conn, table, name, code, cb) {
// assuming that connection to the database is established and stored as conn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rework: I didn't see the answer for the first question in 3.3?

Give an example of a value that can be passed as name and code that would take advantage of SQL-injection and ( fetch all the records in the database)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still didn't see the answer for this question?

await connection.execute(
`
insert into account_changes (account_no,amount,change_date,remark)
values (?,?,now(),?)`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to use NOW() here 👍

Copy link

@yunchen4 yunchen4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Rizan,

Nice work done on the mongodb exercises. But I still didn't see the answer for SQL injection question 1?

Copy link

@yunchen4 yunchen4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants