feat: add one-shot sticky modifiers#720
Conversation
Binary Size Reportuse_config/nrf52832_bleDiffuse_config/nrf52840_bleDiffuse_config/nrf52840_ble_splitDiffCentral DiffPeripheral Diffuse_rust/nrf52840_ble_splitDiffCentral DiffPeripheral Diffuse_config/pi_pico_w_bleDiffuse_config/pi_pico_w_ble_splitDiffCentral DiffPeripheral Diffuse_rust/pi_pico_w_ble_splitDiffCentral DiffPeripheral Diffuse_config/rp2040Diffuse_config/rp2040_splitDiffCentral DiffPeripheral Diffuse_rust/rp2040_splitDiffCentral DiffPeripheral Diffuse_config/stm32f1Diffuse_config/stm32f4Diffuse_config/stm32h7Diff |
de53682 to
3f613b6
Compare
ce8b966 to
f3a9186
Compare
|
Updated the docs, squashed all WIP commits. |
360291e to
010c139
Compare
|
@HaoboGu Some tests failed, but I can't figure out why. Is |
|
I've fixed the test |
|
When If the second tap of the same OSM cancels(releases) itself, when |
Why?
No, this is not quite right. When |
Fair enough. The only thing I'm thinking about now is: Is "Tap the same OSSM key for the second time within the timeout time: cancel current OSSM" default behavior when But if there are other cases which need |
On the one hand, we need On the other hand, making this behavior default will make this behavior "smarter". But I don't think that the code simplicity wins against better configurability. So, it's up to you to decide which way it should be |
I’d like to keep the configuration simple. For now, the |
5092e31 to
6d04815
Compare
|
Synced with the upstream and removed Please, check that everything is okay. |
HaoboGu
left a comment
There was a problem hiding this comment.
It looks nice now, only a minor import fix here
Fixed. Ready to merge? |
Yes! Thanks a lot for your effort! |
Added One-Shot Sticky Modifiers functionality
Moved OSM/OSL logic into
oneshot.rsfileAdded two boolean config variables:
activate_on_keypress: Should modifiers be active from keypress (sticky modifiers)send_on_second_press: Should the second keypress send modifiers and unstick themUpdated
behavior.mddocs to correspond with the new config structure: