Skip to content

Allow trailing commas in join_all and with_feature macros#777

Merged
HaoboGu merged 1 commit intoHaoboGu:mainfrom
Limeth:macro-trailing-commas
Mar 21, 2026
Merged

Allow trailing commas in join_all and with_feature macros#777
HaoboGu merged 1 commit intoHaoboGu:mainfrom
Limeth:macro-trailing-commas

Conversation

@Limeth
Copy link
Contributor

@Limeth Limeth commented Mar 21, 2026

Small quality of life change

@github-actions
Copy link

Binary Size Report

use_config/nrf52832_ble

   text	   data	    bss	    dec	    hex	filename
 315708	   5104	  33736	 354548	  568f4	rmk-nrf52832
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +6  [ = ]       0    .debug_str
  -0.0%      -2  [ = ]       0    .strtab
  +0.0%      +4  [ = ]       0    TOTAL

use_config/nrf52840_ble

   text	   data	    bss	    dec	    hex	filename
 352208	   5104	  47704	 405016	  62e18	rmk-nrf52840
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -1  [ = ]       0    .strtab
  -4.1%      -2  [ = ]       0    [Unmapped]
  -0.0%      -5  [ = ]       0    .debug_str
  -0.0%      -8  [ = ]       0    TOTAL

use_config/nrf52840_ble_split

   text	   data	    bss	    dec	    hex	filename
 430840	   6428	  45624	 482892	  75e4c	central

   text	   data	    bss	    dec	    hex	filename
 276432	   5792	  26696	 308920	  4b6b8	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  [ = ]       0    .debug_str
  +1.7%      +1  [ = ]       0    [Unmapped]
  -0.0%      -1  [ = ]       0    .strtab
  +0.0%      +4  [ = ]       0    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  [ = ]       0    .debug_str
  +0.0%      +4  [ = ]       0    TOTAL

use_rust/nrf52840_ble_split

   text	   data	    bss	    dec	    hex	filename
 433708	   6428	  51336	 491472	  77fd0	central

   text	   data	    bss	    dec	    hex	filename
 274368	   5232	  25440	 305040	  4a790	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  [ = ]       0    .debug_str
  +2.4%      +1  [ = ]       0    [Unmapped]
  -0.0%      -1  [ = ]       0    .strtab
  +0.0%      +4  [ = ]       0    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  [ = ]       0    .debug_str
  +0.0%      +4  [ = ]       0    TOTAL

use_config/pi_pico_w_ble

   text	   data	    bss	    dec	    hex	filename
 597568	      0	  54712	 652280	  9f3f8	rmk-pi-pico-w
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +6.5%      +3  [ = ]       0    [Unmapped]
  +0.0%      +1  [ = ]       0    .strtab
  +0.0%      +4  [ = ]       0    TOTAL

use_config/pi_pico_w_ble_split

   text	   data	    bss	    dec	    hex	filename
 629120	      0	  61240	 690360	  a88b8	central

   text	   data	    bss	    dec	    hex	filename
 493276	      0	  41924	 535200	  82aa0	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  [ = ]       0    .strtab
  +0.0%      +4  [ = ]       0    TOTAL

use_rust/pi_pico_w_ble_split

   text	   data	    bss	    dec	    hex	filename
 629676	      0	  61560	 691236	  a8c24	central

   text	   data	    bss	    dec	    hex	filename
 493764	      0	  41924	 535688	  82c88	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  [ = ]       0    .strtab
  +0.0%      +4  [ = ]       0    TOTAL

use_config/rp2040

   text	   data	    bss	    dec	    hex	filename
 135584	      0	  15836	 151420	  24f7c	rmk-rp2040
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +8.5%      +4  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .debug_str
  -0.0%      -6  [ = ]       0    .strtab
  -0.0%      -4  [ = ]       0    TOTAL

use_config/rp2040_split

   text	   data	    bss	    dec	    hex	filename
 147108	      0	  16864	 163972	  28084	central

   text	   data	    bss	    dec	    hex	filename
  23572	     56	   2492	  26120	   6608	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -1  [ = ]       0    .strtab
  -2.3%      -1  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_str
  -0.0%     -12  [ = ]       0    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -2  [ = ]       0    .strtab
  -0.0%     -10  [ = ]       0    .debug_str
  -0.0%     -12  [ = ]       0    TOTAL

use_rust/rp2040_split

   text	   data	    bss	    dec	    hex	filename
 145772	      0	  16468	 162240	  279c0	central

   text	   data	    bss	    dec	    hex	filename
  24300	     56	   2756	  27112	   69e8	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +8.8%      +3  [ = ]       0    [Unmapped]
  -0.0%      -1  [ = ]       0    .strtab
  -0.0%     -10  [ = ]       0    .debug_str
  -0.0%      -8  [ = ]       0    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -2  [ = ]       0    .strtab
  -0.0%     -10  [ = ]       0    .debug_str
  -0.0%     -12  [ = ]       0    TOTAL

use_config/stm32f1

   text	   data	    bss	    dec	    hex	filename
  57288	     24	   8072	  65384	   ff68	rmk-stm32f1
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

use_config/stm32f4

   text	   data	    bss	    dec	    hex	filename
 135984	    320	  16556	 152860	  2551c	rmk-stm32f4
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -2  [ = ]       0    .strtab
  -4.5%      -3  [ = ]       0    [Unmapped]
  -0.0%      -7  [ = ]       0    .debug_str
  -0.0%     -12  [ = ]       0    TOTAL

use_config/stm32h7

   text	   data	    bss	    dec	    hex	filename
  98280	    264	  10684	 109228	  1aaac	rmk-stm32h7
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Copy link
Owner

@HaoboGu HaoboGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@HaoboGu HaoboGu merged commit aed0972 into HaoboGu:main Mar 21, 2026
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants