Fix redundant dependency invalidations#12860
Open
RblSb wants to merge 1 commit intoHaxeFoundation:developmentfrom
Open
Fix redundant dependency invalidations#12860RblSb wants to merge 1 commit intoHaxeFoundation:developmentfrom
RblSb wants to merge 1 commit intoHaxeFoundation:developmentfrom
Conversation
Member
|
Hmm, the question here is what happens with those in the cache. If they live on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now after i update dependency file, build macro will not be called on every other module focus/save, only on actual dependency updates or macro module updates.
This
let fake_modulesseems like another leftover from #11482 (comment)Also, i wonder if fake modules can be added with
~skip_postprocess:truethere?haxe/src/typing/macroContext.ml
Line 529 in d800964
Closes #12846