Skip to content

Fix redundant dependency invalidations#12860

Open
RblSb wants to merge 1 commit intoHaxeFoundation:developmentfrom
RblSb:deps-invalidation
Open

Fix redundant dependency invalidations#12860
RblSb wants to merge 1 commit intoHaxeFoundation:developmentfrom
RblSb:deps-invalidation

Conversation

@RblSb
Copy link
Copy Markdown
Member

@RblSb RblSb commented Mar 23, 2026

Now after i update dependency file, build macro will not be called on every other module focus/save, only on actual dependency updates or macro module updates.

This let fake_modules seems like another leftover from #11482 (comment)

Also, i wonder if fake modules can be added with ~skip_postprocess:true there?

add_dependency m (TypeloadCacheHook.create_fake_module ctx.com file) MDepFromMacro;

Closes #12846

@Simn
Copy link
Copy Markdown
Member

Simn commented Mar 23, 2026

Hmm, the question here is what happens with those in the cache. If they live on com then it would seem that they aren't available anymore after the current compilation finishes. I definitely agree with removing this global state, but we need to check if it's really correct like this.

@kLabz kLabz self-requested a review March 26, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Context.registerModuleDependency/getBuildFields behavior change

2 participants