Open
Conversation
cofinley
commented
Sep 17, 2019
cofinley
commented
- Allow for whole packages, not just single-file addons
- Don't force before/after functions to be present
- Fix keyboard shortcut
- Change to PyQt5 syntax for some triggers
_() translation function was not the function to use here. QKeySequence is what recognizes shortcuts.
If reloading an addon that creates a Tools menu item on init, there will be duplicate items. This has to be handled on a case-by-case basis since not all addons are initialized the same way or even have menu items. Tell users how to avoid this if they wish to do so.
Owner
|
Hi, sorry I took so long to look at this. It seems like a substantial rewrite, or more like your new addon based on mine, so I'd be reluctant to take responsibility for it. If you'd like to share your version on AnkiWeb yourself, I could put a link in the readme over here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.