Skip to content

re-added the example config file and made tests work #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicholasEymann wants to merge 1 commit into
base: master
Choose a base branch
from
Open

re-added the example config file and made tests work #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,21 +457,21 @@ Setup and install
```
Copy link
Contributor Author

@NicholasEymann NicholasEymann Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating the readme to reflect changes in how tests are run

git clone ssh+git@github.com:HeliosInteractive/reachjs.git
cd reachjs &&\
npm install && npm install grunt grunt-cli -g
npm install
```

**Development and testing**

```
grunt dev
npm run dev
```

The dev task will run watch and a connect static server on port 8000. Open `http://127.0.0.1:8000/test/html/test.html` to run
the automated browser tests.

> copy test/config.dist.js to test/config.js and set your api key for testing
> copy test/config.example.js to test/config.js and set your api key for testing

Run `grunt mochaTest` to test the node components
Run `npm test` to test the node components

---

Expand Down
4 changes: 4 additions & 0 deletions test/config.example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = function(reach) {
Copy link
Contributor Author

@NicholasEymann NicholasEymann Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the file that got deleted that every test calls to set up the reach auth

reach.setUrl("");
reach.key = "";
};
2 changes: 0 additions & 2 deletions test/post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ try{
}
Copy link
Contributor Author

@NicholasEymann NicholasEymann Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason these authentication calls were put into the individual test pages. That's unnecessary with the included config file.


var activation = "1e637007-f4bc-4ad2-bc0c-386550df6662";
reach.setUrl("http://reachstaging.herokuapp.com/api/");
reach.key = "helios_test";

describe('Reach POST', function() {

Expand Down
3 changes: 0 additions & 3 deletions test/put.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ try{
require('./config.js')(reach);
}

reach.setUrl("http://reachstaging.herokuapp.com/api/");
reach.key = "helios_test";

describe('Reach PUT', function() {

it("Should update a guest", function(done){
Expand Down