re-added the example config file and made tests work#3
Open
NicholasEymann wants to merge 1 commit intomasterfrom
Open
re-added the example config file and made tests work#3NicholasEymann wants to merge 1 commit intomasterfrom
NicholasEymann wants to merge 1 commit intomasterfrom
Conversation
NicholasEymann
commented
Nov 8, 2018
| @@ -457,21 +457,21 @@ Setup and install | |||
| ``` | |||
Contributor
Author
There was a problem hiding this comment.
updating the readme to reflect changes in how tests are run
NicholasEymann
commented
Nov 8, 2018
| @@ -0,0 +1,4 @@ | |||
| module.exports = function(reach) { | |||
Contributor
Author
There was a problem hiding this comment.
this is the file that got deleted that every test calls to set up the reach auth
NicholasEymann
commented
Nov 9, 2018
| @@ -12,8 +12,6 @@ try{ | |||
| } | |||
Contributor
Author
There was a problem hiding this comment.
for some reason these authentication calls were put into the individual test pages. That's unnecessary with the included config file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got these tests working, but not without adding/changing a bunch of things. It seems the tests were originally written to use grunt and somewhere along the line the example config file got deleted.