Add PacketBuffer docs #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jun 5, 2024
lib/src/packet_buffer.dart
Outdated
| return _length - _cursor; | ||
| } | ||
|
|
||
| /// Marks all bytes as unread. |
There was a problem hiding this comment.
not all of them, only those up to the last checkpoint
Hixie
reviewed
Jun 5, 2024
lib/src/packet_buffer.dart
Outdated
| } | ||
| _cursor += length; | ||
| return bytes.buffer.asUint8List(bytes.offsetInBytes + packetOffset, length); | ||
| return bytes.buffer |
There was a problem hiding this comment.
avoid reformatting in the same patch that makes logic changes, it makes it hard to review the pr
Hixie
reviewed
Jun 5, 2024
lib/src/packet_buffer.dart
Outdated
| packet.offsetInBytes + _start, | ||
| packet.length - _start, | ||
| ), | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.