Replace instances of update_attributes with update to avoid deprecation warnings in Rails 6. #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on warnings in Rails 6.
|
Are there any blockers to get this merged? |
…if the request format is something else than html or json
Fix handle_failed_second_factor so that it just doesn't fall through if the request format is something else than html or json
Show authentication type in the json response when 2fa required
Switch resend_code to use POST
Don't resend otp code to user if we're in one of the configured scopes to skip it
|
Are there any blockers to get this merged? |
|
Getting this merged would be great! |
Sync with upstream
Rails 8 support
…version-in-two_factor_authentication SEL-8698: Integer to time conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170.