Skip to content

Conversation

yyassi-heartex
Copy link
Contributor

This pull request introduces improvements to the tab component styling for better theme consistency and updates the tab state management to persist the agreement_selected property. These changes help ensure that the tab UI matches the application's color scheme and that user selections are properly saved and restored.

Styling and Theming:

  • Updated the background colors in the _virtual and _virtual.tabs-dm__item_active classes of Tabs.scss to use theme variables (--color-neutral-background, --color-neutral-surface, --color-neutral-border-subtle) instead of hardcoded color values for improved consistency and maintainability.

State Management:

  • Added the agreement_selected property to the tab snapshot and serialization methods in tab.js, ensuring that this state is persisted and restored with each tab. [1] [2]

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner September 19, 2025 18:23
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 4e222d5
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/68d6e60abb95280008ffae57

Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 4e222d5
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/68d6e60a0e2ed20008dbc9c5

Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 4e222d5
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68d6e60ace17330008e56ea4
😎 Deploy Preview https://deploy-preview-8481--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the feat label Sep 19, 2025
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 4e222d5
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68d6e60a25282f00087b8af1
😎 Deploy Preview https://deploy-preview-8481--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.60%. Comparing base (1bfd44f) to head (4e222d5).
⚠️ Report is 4 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (1bfd44f) and HEAD (4e222d5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1bfd44f) HEAD (4e222d5)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8481      +/-   ##
===========================================
- Coverage    66.45%   60.60%   -5.85%     
===========================================
  Files          780      543     -237     
  Lines        59639    38385   -21254     
  Branches     10136    10136              
===========================================
- Hits         39635    23265   -16370     
+ Misses       20001    15117    -4884     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 54.77% <ø> (+2.81%) ⬆️
lsf-integration 51.34% <ø> (-0.02%) ⬇️
lsf-unit 8.61% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yyassi-heartex yyassi-heartex requested a review from a team September 23, 2025 13:55
@yyassi-heartex yyassi-heartex requested a review from a team as a code owner September 25, 2025 18:10
@yyassi-heartex yyassi-heartex force-pushed the fb-fit-698/agreement_selected branch from 96c859f to 88985ab Compare September 25, 2025 18:45
@robot-ci-heartex robot-ci-heartex merged commit 3f41aa1 into develop Sep 26, 2025
45 of 46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-698/agreement_selected branch September 26, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants