Skip to content

Conversation

@hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Nov 17, 2025

No value is also a value and this should be counted in agreement calculations.

Removed all controls, making countEmpty and showEmpty true by default.

No value is also a value and this should be counted in agreement calculations.

Removed all controls, making `countEmpty` and `showEmpty` true by default.
@hlomzik hlomzik requested a review from niklub November 17, 2025 20:10
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 3f63c6b
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/691ccf41dfb121000849703a

@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 3f63c6b
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/691ccf41b037b80008cf5c24
😎 Deploy Preview https://deploy-preview-8836--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 3f63c6b
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/691ccf412ad2e20008756f9a

@github-actions github-actions bot added the fix label Nov 17, 2025
@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 3f63c6b
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/691ccf417e862c000843384c
😎 Deploy Preview https://deploy-preview-8836--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.50%. Comparing base (ef83d11) to head (3f63c6b).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
.../editor/src/components/TaskSummary/Aggregation.tsx 60.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ef83d11) and HEAD (3f63c6b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ef83d11) HEAD (3f63c6b)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8836      +/-   ##
===========================================
- Coverage    65.87%   58.50%   -7.38%     
===========================================
  Files          812      554     -258     
  Lines        63602    40187   -23415     
  Branches     10761    10756       -5     
===========================================
- Hits         41899    23510   -18389     
+ Misses       21699    16673    -5026     
  Partials         4        4              
Flag Coverage Δ
lsf-e2e 52.67% <0.00%> (+2.32%) ⬆️
lsf-integration 49.14% <0.00%> (+0.02%) ⬆️
lsf-unit 8.35% <71.42%> (-0.04%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hlomzik
Copy link
Collaborator Author

hlomzik commented Nov 18, 2025

/fmt

Workflow run

@hlomzik
Copy link
Collaborator Author

hlomzik commented Nov 19, 2025

/git merge

Workflow run
Successfully merged: Already up to date.

@hlomzik
Copy link
Collaborator Author

hlomzik commented Nov 19, 2025

/git merge

Workflow run
Successfully merged: Already up to date.

@robot-ci-heartex robot-ci-heartex merged commit 620b10c into develop Nov 19, 2025
99 of 106 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-bros-594/count-empty branch November 19, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants