Skip to content

fix: BROS-626: Fix shape corruption when hitting image constraints #8842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
Merged

fix: BROS-626: Fix shape corruption when hitting image constraints #8842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa54c02
Fix shape corruption when hitting image constraints
nick-skriabin Nov 18, 2025
4f1d31d
Merge branch 'develop' into 'fb-bros-626'
nick-skriabin Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 20 additions & 25 deletions web/libs/editor/src/components/KonvaVector/utils/boundsChecking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,16 @@ export function constrainAnchorPointsToBounds(
y: number;
controlPoint1?: { x: number; y: number };
controlPoint2?: { x: number; y: number };
[key: string]: any; // Allow additional properties (id, prevPointId, isBezier, etc.)
}>,
bounds: { width: number; height: number },
): Array<{ x: number; y: number; controlPoint1?: { x: number; y: number }; controlPoint2?: { x: number; y: number } }> {
): Array<{
x: number;
y: number;
controlPoint1?: { x: number; y: number };
controlPoint2?: { x: number; y: number };
[key: string]: any;
}> {
if (points.length === 0) return points;

// Calculate the bounding box of only the anchor points (not control points)
Expand Down Expand Up @@ -161,13 +168,11 @@ export function constrainAnchorPointsToBounds(
}

// Apply the constraint to anchor points and their control points
// Preserve all properties from the original point (id, prevPointId, isBezier, etc.)
const constrainedPoints = points.map((point) => {
const constrainedPoint: {
x: number;
y: number;
controlPoint1?: { x: number; y: number };
controlPoint2?: { x: number; y: number };
} = {
// Spread all properties from the original point to preserve skeleton relationships
const constrainedPoint = {
...point,
x: point.x + deltaX,
y: point.y + deltaY,
};
Expand All @@ -190,14 +195,6 @@ export function constrainAnchorPointsToBounds(
});

// Debug logging
console.log("Anchor points constraint applied:", {
originalAnchorBbox: anchorBbox,
delta: { x: deltaX, y: deltaY },
bounds,
constrainedAnchorBbox: calculateGroupBoundingBox(constrainedPoints.map((p) => ({ x: p.x, y: p.y }))),
pointCount: points.length,
});

return constrainedPoints;
}

Expand Down Expand Up @@ -283,15 +280,6 @@ export function calculateTransformerConstraints(
needsConstraint = true;
}

// Debug logging (can be removed later)
if (needsConstraint) {
console.log("CONSTRAINT APPLIED:", {
transformerInImageCoords,
imageBounds,
constrained: { x: constrainedX, y: constrainedY },
});
}

return needsConstraint ? { x: constrainedX, y: constrainedY } : null;
}

Expand All @@ -308,9 +296,16 @@ export function constrainGroupToBounds(
y: number;
controlPoint1?: { x: number; y: number };
controlPoint2?: { x: number; y: number };
[key: string]: any; // Allow additional properties (id, prevPointId, isBezier, etc.)
}>,
bounds: { width: number; height: number },
): Array<{ x: number; y: number; controlPoint1?: { x: number; y: number }; controlPoint2?: { x: number; y: number } }> {
): Array<{
x: number;
y: number;
controlPoint1?: { x: number; y: number };
controlPoint2?: { x: number; y: number };
[key: string]: any;
}> {
if (points.length === 0) return points;

// Only constrain anchor points as a group
Expand Down
Loading