Skip to content

Conversation

@yyassi-heartex
Copy link
Contributor

This pull request simplifies the AgreementSelectedWrapper component in the TableHead by removing unnecessary state management related to the dropdown's open/close state. The logic now relies solely on the dropdown's internal state, streamlining the component.

screen-recorder-thu-nov-20-2025-21-57-32.webm

Component simplification:

  • Removed the useState hook and all related logic (isOpen, setIsOpen, and onToggle) from the AgreementSelectedWrapper component, relying instead on the dropdown's own state management. ([[1]](https://github.com/HumanSignal/label-studio/pull/8860/files#diff-51ab382cac0e258f4e4a21289401f0fda6d405059dae8badcc56b0c9e2bc8d5dL3-R3), [[2]](https://github.com/HumanSignal/label-studio/pull/8860/files#diff-51ab382cac0e258f4e4a21289401f0fda6d405059dae8badcc56b0c9e2bc8d5dL75-L102))

@yyassi-heartex yyassi-heartex requested a review from a team as a code owner November 21, 2025 02:58
@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 8a04ac0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/691fd54826746f00088ab863

@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 8a04ac0
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/691fd548deda2c000875ea66

@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 8a04ac0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/691fd5482da24a0008f93aee
😎 Deploy Preview https://deploy-preview-8860--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Nov 21, 2025
@yyassi-heartex yyassi-heartex requested a review from a team November 21, 2025 02:58
@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 8a04ac0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/691fd54819508c0008e3f63f
😎 Deploy Preview https://deploy-preview-8860--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.42%. Comparing base (b8f542e) to head (8a04ac0).
⚠️ Report is 1 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (b8f542e) and HEAD (8a04ac0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b8f542e) HEAD (8a04ac0)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8860      +/-   ##
===========================================
- Coverage    66.73%   58.42%   -8.32%     
===========================================
  Files          812      554     -258     
  Lines        63804    40287   -23517     
  Branches     10790    10790              
===========================================
- Hits         42582    23537   -19045     
+ Misses       21218    16746    -4472     
  Partials         4        4              
Flag Coverage Δ
lsf-e2e 52.42% <ø> (-0.01%) ⬇️
lsf-integration 49.10% <ø> (ø)
lsf-unit 8.35% <ø> (ø)
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robot-ci-heartex robot-ci-heartex merged commit 007af00 into develop Nov 21, 2025
45 of 46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-1030/agreement-selected-dropdown branch November 21, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants