-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: FIT-1030: Agreement Selected dropdown is broken #8860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: FIT-1030: Agreement Selected dropdown is broken #8860
Conversation
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8860 +/- ##
===========================================
- Coverage 66.73% 58.42% -8.32%
===========================================
Files 812 554 -258
Lines 63804 40287 -23517
Branches 10790 10790
===========================================
- Hits 42582 23537 -19045
+ Misses 21218 16746 -4472
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request simplifies the
AgreementSelectedWrappercomponent in theTableHeadby removing unnecessary state management related to the dropdown's open/close state. The logic now relies solely on the dropdown's internal state, streamlining the component.screen-recorder-thu-nov-20-2025-21-57-32.webm
Component simplification:
useStatehook and all related logic (isOpen,setIsOpen, andonToggle) from theAgreementSelectedWrappercomponent, relying instead on the dropdown's own state management. ([[1]](https://github.com/HumanSignal/label-studio/pull/8860/files#diff-51ab382cac0e258f4e4a21289401f0fda6d405059dae8badcc56b0c9e2bc8d5dL3-R3),[[2]](https://github.com/HumanSignal/label-studio/pull/8860/files#diff-51ab382cac0e258f4e4a21289401f0fda6d405059dae8badcc56b0c9e2bc8d5dL75-L102))