Conversation
b389175 to
0bc0caf
Compare
9ae8d11 to
30b37bd
Compare
|
@frjo I'm going to add a unit test for the results view, some docs & do a final look over but it should be ready for review if you wanted to take a look before that |
| SubmissionSkeletonFilter.declared_filters | ||
| ) | ||
| if not set(self.request.GET) & set(non_skeleton_fields): | ||
| skeleton_qs = SubmissionSkeletonFilter( |
There was a problem hiding this comment.
somewhat of a hacky solution to managing 2 models with one FilterView but seems to work?
There was a problem hiding this comment.
seems like the # of SQL queries shoots up though so might need some optimizing
…th wagtail & submission views
…ail form if enabled
30b37bd to
a5e160a
Compare
|
@wes-otf I rebased this with main to solve a small merge conflict. |
…e actions section.
|
@wes-otf When I was testing this I realised we have some existing issues with deleted/archive. When I started with fixing that more things followed as you can see in the PR now 😄.
My changes:
|
|
The batch functions on submission/all only have a simple js alert while the same functions for a single submission has a nice modal. That is not logical. Will fix that in a separate PR. |
frjo
left a comment
There was a problem hiding this comment.
This works very well in my testing, the backend seems solid. The anonymised submission has very little information left since all form_data is deleted. The feature talk about removing PII info, some might be surprised that almost nothing besides the value remain.
Maybe this can be communicated better?
Would close #3441. Adds a new AnonymizedSubmission model that only contains minimal, non-PII datapoints. Also adds UI features for staff to select whether a user's application(s) should be deleted or converted to skeletoned/anonymized application.
The todos:
Test Steps