Address @smnnlt follow-up: streamline tests and remove purrr#19
Merged
Conversation
- rewrote test suite from ~600 to 373 focused assertions (0 fail / 0 warn / 0 skip on local devtools::test()) - replaced expect_true(is.data.frame()) with expect_s3_class(), expect_equal(length()) with expect_length() - removed redundant gg-class checks now covered by vdiffr snapshots - deleted test-smoke-and-errors.R, test-uncovered-branches.R and other fragmented test files - replaced mock helpers with inst/extdata/ example data where possible - removed purrr from dependencies entirely - removed CITATION.cff (flagged by R CMD check) - cleaned up NAMESPACE, DESCRIPTION, and .Rbuildignore - R CMD check: 0 errors, 0 warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the remaining points raised by @smnnlt in the final follow-up review:
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 373 ]expect_true(is.data.frame())withexpect_s3_class(),expect_equal(length())withexpect_length(), removed redundant gg-class checks (already covered by vdiffr snapshots)test-smoke-and-errors.R,test-uncovered-branches.R, etc.) and consolidated into per-feature test filesinst/extdata/example data via sharedhelper-test-data.Rwhere possiblepurrr::transpose())Verification
devtools::test(): FAIL 0 | WARN 0 | SKIP 0 | PASS 373devtools::check(): 0 errors, 0 warnings, 1 note (unable to verify current time)