Skip to content

Remove forced getrandom js feature#59

Merged
Forpee merged 1 commit intoICME-Lab:mainfrom
SpaceManiac:patch/getrandom-js
Jul 10, 2025
Merged

Remove forced getrandom js feature#59
Forpee merged 1 commit intoICME-Lab:mainfrom
SpaceManiac:patch/getrandom-js

Conversation

@SpaceManiac
Copy link
Copy Markdown
Contributor

getrandom's documentation says about the js Cargo feature:

Library crates should generally not enable this feature, leaving such a decision to users of their library.

The effect of this feature inclusion is that WebAssembly consumers of the zk-engine crate are forcibly locked in to using wasm-bindgen rather than supplying their own getrandom backend, which can be inconvenient.

This dependency block has been present since the initial commit 05529dc.

See also wyattbenno777/arecibo#28.

@Forpee Forpee merged commit cd3c52d into ICME-Lab:main Jul 10, 2025
1 of 2 checks passed
SpaceManiac added a commit to LFDT-Nightstream/Starstream that referenced this pull request Jul 10, 2025
@SpaceManiac SpaceManiac deleted the patch/getrandom-js branch July 10, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants