Skip to content

Bluetooth#102

Open
Raphsinai wants to merge 6 commits intomasterfrom
bluetooth
Open

Bluetooth#102
Raphsinai wants to merge 6 commits intomasterfrom
bluetooth

Conversation

@Raphsinai
Copy link
Contributor

added bluetooth tracking commands

Copy link
Member

@ohmdelta ohmdelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SHORTCODE_REGEX = r'^[a-z]{2,3}\d{2,5}$'
UID_REGEX = r'^[0-9A-F]{8,14}$'
DISCORD_ID_REGEX = r'^<@[0-9]{18,19}>$'
MAC_ADDR_REGEX = r'^([0-9A-F]{2}:){5}[0-9A-F]{2}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add $ at end

return Stats()

def get_mac_addresses_from_shortcode(shortcode: str):
res = requests.get(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally best to return response obj directly - allows you to handle different status codes differently in different scenarios

timestamp: str,
interval: int,
):
return await trained_member_present(interaction, timestamp, interval)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? might be nicer to have a status page + webhook like how the printer streaming stuff is done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants