Skip to content

Wings3D#228

Open
AnnaDelbeke wants to merge 10 commits intoIDEALLab:mainfrom
AnnaDelbeke:wings3D
Open

Wings3D#228
AnnaDelbeke wants to merge 10 commits intoIDEALLab:mainfrom
AnnaDelbeke:wings3D

Conversation

@AnnaDelbeke
Copy link

Description

This PR adds the initial Wings3D problem implementation including:

  • Dataset loading from HuggingFace (Cashen/optiwing3d_engibench)
  • Random wing design generation
  • Placeholder simulation returning dummy drag/lift values
  • Placeholder optimization pipeline

This establishes the basic problem structure so that the real simulation and optimization methods can be implemented next.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have run ruff check . and ruff format
  • I have run mypy .
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Reviewer Checklist:

  • The content of this PR brings value to the community. It is not too specific to a particular use case.
  • The tests and checks pass (linting, formatting, type checking). For a new problem, double check the github actions workflow to ensure the problem is being tested.
  • The documentation is updated.
  • The code is understandable and commented. No large code blocks are left unexplained, no huge file. Can I read and understand the code easily?
  • There is no merge conflict.
  • The changes are not breaking the existing results (datasets, training curves, etc.). If they do, is there a good reason for it? And is the associated problem version bumped?
  • For a new problem, has the dataset been generated with our slurm script so we can re-generate it if needed? (This also ensures that the problem is running on the HPC.)
  • For bugfixes, it is a robust fix and not a hacky workaround.

…lator/optimizer)

- Refactor Airfoil class to Wings3D with 9-slice 3D design space (9x192x2)
- Add dataset loader with HuggingFace fallback to local .pkl/.parquet files
- Update utils to handle 3D coordinates and slice operations
- Add new CFD simulation templates (wings3D_analysis.py, wings3D_opt.py)
- Update module imports, problem registration, and remove obsolete files
- Change dataset ID to "Cashen/optiwing3d_engibench"
- Note: simulate() and optimize() use dummy implementations until 3D CFD is integrated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant