Merged
Conversation
Updates to airfoil slurm dataset generator example Minor edits cleaning up dataset generator scripts before creating PR Ruff checks fixes Remove deprecated slurm airfoil script, fix linting
3397c71 to
004b344
Compare
markfuge
reviewed
Mar 16, 2026
| name="Airfoil_dataset_generation", | ||
| runtime=calculate_runtime(group_size, minutes_per_sim=5), | ||
| runtime=calculate_runtime(group_size, minutes_per_sim=15), | ||
| account="fuge-prj-jrl", |
Member
There was a problem hiding this comment.
@fgvangessel-umd Should this be hard-coded? Perhaps better passed as an argument.
Contributor
Author
There was a problem hiding this comment.
Good catch that should be a required argument. I've fixed locally and will push later today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added functionality to generate airfoil problem datasets using SLURM. The three files changed in the PR are:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .Reviewer Checklist: