Skip to content

Airfoil dataset generator#229

Merged
fgvangessel-umd merged 1 commit intomainfrom
airfoil-dataset-generator
Mar 16, 2026
Merged

Airfoil dataset generator#229
fgvangessel-umd merged 1 commit intomainfrom
airfoil-dataset-generator

Conversation

@fgvangessel-umd
Copy link
Contributor

Description

I have added functionality to generate airfoil problem datasets using SLURM. The three files changed in the PR are:

  • dataset_slurm_airfoil.py which is the main file that takes command-line arguments and creates an array of airfoil geometries and flow conditions passing them to simulator
  • simulation_jobs.py: Contains the python function that simulates an individual airfoil case, this is passed to the SLURM object
  • init.py: Minor change to allow passing a specific allocation for SLURM job charging

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have run ruff check . and ruff format
  • [X]I have run mypy .
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Reviewer Checklist:

  • The content of this PR brings value to the community. It is not too specific to a particular use case.
  • The tests and checks pass (linting, formatting, type checking). For a new problem, double check the github actions workflow to ensure the problem is being tested.
  • The documentation is updated.
  • The code is understandable and commented. No large code blocks are left unexplained, no huge file. Can I read and understand the code easily?
  • There is no merge conflict.
  • The changes are not breaking the existing results (datasets, training curves, etc.). If they do, is there a good reason for it? And is the associated problem version bumped?
  • For a new problem, has the dataset been generated with our slurm script so we can re-generate it if needed? (This also ensures that the problem is running on the HPC.)
  • For bugfixes, it is a robust fix and not a hacky workaround.

Updates to airfoil slurm dataset generator example

Minor edits cleaning up dataset generator scripts before creating PR

Ruff checks fixes

Remove deprecated slurm airfoil script, fix linting
@fgvangessel-umd fgvangessel-umd force-pushed the airfoil-dataset-generator branch from 3397c71 to 004b344 Compare March 16, 2026 18:38
@fgvangessel-umd fgvangessel-umd merged commit e5d403c into main Mar 16, 2026
15 checks passed
@fgvangessel-umd fgvangessel-umd deleted the airfoil-dataset-generator branch March 16, 2026 18:48
name="Airfoil_dataset_generation",
runtime=calculate_runtime(group_size, minutes_per_sim=5),
runtime=calculate_runtime(group_size, minutes_per_sim=15),
account="fuge-prj-jrl",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgvangessel-umd Should this be hard-coded? Perhaps better passed as an argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch that should be a required argument. I've fixed locally and will push later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants