Skip to content

Airfoil dataset generator#230

Merged
fgvangessel-umd merged 3 commits intomainfrom
airfoil-dataset-generator
Mar 18, 2026
Merged

Airfoil dataset generator#230
fgvangessel-umd merged 3 commits intomainfrom
airfoil-dataset-generator

Conversation

@fgvangessel-umd
Copy link
Contributor

Description

Fixed issue where the Slurm airfoil example had hardcoded account allocation charge. This now now a required argument to using the functionality. I also created the option to toggle between simulate and optimization analysis although the optimization capability is not yet implemented.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have run ruff check . and ruff format
  • I have run mypy .
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Reviewer Checklist:

  • The content of this PR brings value to the community. It is not too specific to a particular use case.
  • The tests and checks pass (linting, formatting, type checking). For a new problem, double check the github actions workflow to ensure the problem is being tested.
  • The documentation is updated.
  • The code is understandable and commented. No large code blocks are left unexplained, no huge file. Can I read and understand the code easily?
  • There is no merge conflict.
  • The changes are not breaking the existing results (datasets, training curves, etc.). If they do, is there a good reason for it? And is the associated problem version bumped?
  • For a new problem, has the dataset been generated with our slurm script so we can re-generate it if needed? (This also ensures that the problem is running on the HPC.)
  • For bugfixes, it is a robust fix and not a hacky workaround.

@fgvangessel-umd fgvangessel-umd force-pushed the airfoil-dataset-generator branch 2 times, most recently from b4bd2ed to 03dc089 Compare March 18, 2026 13:35
@fgvangessel-umd fgvangessel-umd force-pushed the airfoil-dataset-generator branch from 03dc089 to dc5dbcd Compare March 18, 2026 13:38
@fgvangessel-umd fgvangessel-umd merged commit 0fd62b4 into main Mar 18, 2026
15 checks passed
@fgvangessel-umd fgvangessel-umd deleted the airfoil-dataset-generator branch March 18, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant