feat: add gradient descent information to thermoelastic2d problem#232
Open
feat: add gradient descent information to thermoelastic2d problem#232
Conversation
…ifies OptiStep API
g-braeunlich
requested changes
Mar 18, 2026
Comment on lines
+28
to
+30
| x: npt.NDArray | None = None # the current design before the gradient update | ||
| x_update: npt.NDArray | None = None # the gradient update step taken by the optimizer | ||
| obj_values_update: npt.NDArray | None = None # how the objective values change after the update step |
Collaborator
There was a problem hiding this comment.
Suggested change
| x: npt.NDArray | None = None # the current design before the gradient update | |
| x_update: npt.NDArray | None = None # the gradient update step taken by the optimizer | |
| obj_values_update: npt.NDArray | None = None # how the objective values change after the update step | |
| x: npt.NDArray | None = None | |
| """the current design before the gradient update""" | |
| x_update: npt.NDArray | None = None | |
| """the gradient update step taken by the optimizer""" | |
| obj_values_update: npt.NDArray | None = None | |
| """how the objective values change after the update step""" |
| return True | ||
| return change < UPDATE_THRESHOLD and iterr >= MIN_ITERATIONS | ||
|
|
||
| def record_step( |
Collaborator
There was a problem hiding this comment.
PLR0913 starts getting annoying.
I would say: lets remove that check.
Could you do
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -132,6 +132,7 @@ ignore = [
"EM102", # f-string-in-exception
"E741", # ambiguous-variable-name
"FIX002", # flake8-fixme (flake8-todos is enough)
+ "PLR0913", # too-many-arguments
"PTH", # flake8-use-pathliband remove the corresponding noqa throughout the codebase?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This pull request adds gradient information to the Thermoelastic2D problem. It also modifies the OptiStep data class to include additional optional fields for gradient information. These fields include:
Type of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist:
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .Reviewer Checklist: