fix(reproducibility): add opt-in strict determinism across trainers#61
Merged
fix(reproducibility): add opt-in strict determinism across trainers#61
Conversation
g-braeunlich
reviewed
Mar 5, 2026
Collaborator
g-braeunlich
left a comment
There was a problem hiding this comment.
Just 2 small suggestions
Contributor
Author
|
@g-braeunlich quick ping when you have a moment: could you confirm yes/no on the latest TF32 guard update in the open thread? If yes, we’ll resolve and merge. Thanks! |
g-braeunlich
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an opt-in strict reproducibility path for all training entrypoints while preserving current default behavior.
engiopt/reproducibility.pywith shared helpers:seed_training(seed)enable_strict_determinism(warn_only=True)make_dataloader_generator(seed)strict_determinism: bool = Falseto all targeted trainingArgsdataclasses.seed_training(args.seed)in each training script.--strict-determinismis passed.shuffle=Trueloaders.--strict-determinism).Fixes SOH-14 (Linear)
Type of change
Screenshots
N/A
Checklist:
Code Quality
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .CleanRL Philosophy (for new/modified algorithms)
tyro--trackflag support--save-modelflag)Algorithm Completeness (for new algorithms)
algorithm.py) and evaluation script (evaluate_algorithm.py) are providedProbleminterfaceDocumentation
Validation
cgan_cnn_2d) run twice on same machine with strict mode and fixed seed; resulting checkpoint tensor hashes matched for both generator and discriminator.warn_only=Truefor nondeterministic ops to warn and continue.