Skip to content

Conversation

@xInfinitYz
Copy link

@xInfinitYz xInfinitYz commented Feb 14, 2024

This is my first ever PR as a contributor to github and to this project, I'm eager to collaborate and learn. I've proposed some changes related to discussion #332 and #333, aiming to support hierarchical partitioning.

I would greatly appreciate your feedback on the following:

  • Code quality and best practices
  • Implementation approach
  • Any potential impact on existing functionalities

I'm looking forward to your constructive feedback and suggestions to improve this PR. Let's work together to make this integration as smooth as possible.

Tasks

  • Allow partition key parameter to all DefaultRepository methods
  • Implement approach to InMemoryRepository
  • Implement Tests
  • Implement Acceptance Tests
  • Add samples for hierarchical partitioning
  • Decide if IEnumerable<string> partitionKeyValues parameter approach is valuable
  • Decide if EventSourcing Repository should benefit from hierarchical partitioning

Copy link
Owner

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thus far, needs a bit more work. Thanks for contributing this.

xInfinitYz and others added 19 commits February 15, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants