DREF: Update logic for DREF status approved#2272
Open
shreeyash07 wants to merge 3 commits intodevelopfrom
Open
DREF: Update logic for DREF status approved#2272shreeyash07 wants to merge 3 commits intodevelopfrom
shreeyash07 wants to merge 3 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 709a516 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shreeyash07
force-pushed
the
fix/dref-approved-updates
branch
from
c3dba09 to
0ea0273
Compare
barshathakuri
requested changes
Mar 13, 2026
Comment on lines
152
to
+153
| const formContentRef = useRef<ElementRef<'div'>>(null); | ||
| const tabListRef = useRef<ElementRef<'div'>>(null); |
Collaborator
There was a problem hiding this comment.
We already have formContentRef.
|
|
||
| const handleTabChange = useCallback((newTab: DrefTabKey) => { | ||
| formContentRef.current?.scrollIntoView(); | ||
| tabListRef.current?.scrollIntoView({ behavior: 'smooth' }); |
Collaborator
There was a problem hiding this comment.
Why do we need to replace the formContentRef?
Comment on lines
119
to
+120
| const formContentRef = useRef<ElementRef<'div'>>(null); | ||
| const tabListRef = useRef<ElementRef<'div'>>(null); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends On
Changes
This PR Ensures:
console.logstatements meant for debugging