Skip to content

UI: prevent item from rendering extra empty properties to get even #10867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iszmais wants to merge 1 commit into
base: release_9
Choose a base branch
from
Open

UI: prevent item from rendering extra empty properties to get even #10867

iszmais wants to merge 1 commit into from
+18 −27

Conversation

@iszmais
Copy link
Contributor

@iszmais iszmais commented Jan 12, 2026

@iszmais iszmais force-pushed the bugfix/ui-item-property-rendering branch from 282baea to 0ae056e Compare January 12, 2026 13:47
@iszmais iszmais mentioned this pull request Jan 12, 2026
Merged
@mjansenDatabay mjansenDatabay added bugfix php Pull requests that update Php code labels Jan 13, 2026
thibsy
thibsy reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iszmais,

Thx a lot for your contribution to the UI framework!

The changes LGTM, I honestly have no idea why it was ever implemented with this A/B-rendering logic, or at least it doesn't make sense to me.

However, I believe these are templates of interest for skin-developers, so I'd like @BettyFromHH to check them real quick, since any issue would remain in release 9 forever =).

Kind regards,
@thibsy (as UI coordinator)

@BettyFromHH
Copy link
Contributor

BettyFromHH commented Jan 16, 2026

Hi @thibsy,
Hi @iszmais,

Next week, the final version of ILIAS 9 will be released, and I want to prevent users with custom skins from encountering problems, as the proposed change would occur immediately if the custom skin isn't updated.

To avoid errors when using custom skins in ILIAS 9, I suggest implementing the changes starting with ILIAS 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thibsy thibsy thibsy left review comments

Assignees

@thibsy thibsy

@oliversamoila oliversamoila

@BettyFromHH BettyFromHH

Labels

bugfix php Pull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iszmais @BettyFromHH @thibsy @mjansenDatabay @oliversamoila