CoDICE l1b singles counters for lo and hi #2514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
approved these changes
Dec 16, 2025
Comment on lines
+457
to
+463
| for variable in val_data.data_vars: | ||
| np.testing.assert_allclose( | ||
| processed_data[variable].values, | ||
| val_data[variable].values, | ||
| rtol=1.2e-5, | ||
| err_msg=f"Mismatch in variable '{variable}'", | ||
| ) |
Collaborator
There was a problem hiding this comment.
I am curious whether the xarray testing function could assert on everything in the dataset for you instead of this loop? I'm good with this approach since that follows what we've done for everything, but curious nonetheless.
lacoak21
merged commit a8a8a79
into
IMAP-Science-Operations-Center:dev
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
L1b validation for counters singles. Tenzin already had code in place for counters processing.
Overview
closes #2165
closes #2147
Updated Files
Testing
Validation test