I-ALiRT - SWE fixes #2517
Open
I-ALiRT - SWE fixes #2517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laspsandoval
force-pushed
the
swapi_fixes
branch
from
4c0c086 to
5fa99a6
Compare
greglucas
reviewed
Dec 18, 2025
Comment on lines
+478
to
+480
| grouped_data = find_groups( | ||
| accumulated_data, (0, 59), "swe_seq", "met", "swe_nom_flag" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Why are we doing this in two locations? We have a find that takes in the flag and the filter_valid_groups which takes in the flag. Since this is only swe-specific at this point what if you put it right after this instead?
# Drop any off-nominal SWE groups
grouped_data = grouped_data.where(
filtered_data["swe_nom_flag"] != 0,
drop=True,
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
The SWE I-ALiRT data is based on a spin period that is exact. During commissioning the spin has been varying. The resolution to this was to create a packet with zero data for all SWE variables, including the variable "swapi_seq_number". The sequence numbers are used to group the data so having duplicate values of "0" was causing the data to be thrown out. This PR addresses that issue.
Updated Files
Testing