Skip to content

Change CDF types of L2/L1D variables for MAG #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greglucas merged 2 commits into from
Dec 18, 2025
Merged

Change CDF types of L2/L1D variables for MAG #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b5846d
force type for generate dataset to use more reasonable CDF types for …
mhairifin Dec 17, 2025
7caceab
use attributes to alter CDF type instead - potentially neater solution
mhairifin Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions imap_processing/cdf/config/imap_mag_l2_variable_attrs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ vector_attrs: &vectors_default
LABL_PTR_1: direction_label
FILLVAL: 9223372036854775807
FORMAT: F12.5
CDF_DATA_TYPE: CDF_FLOAT
DICT_KEY: "SPASE>Field>FieldQuantity:Magnetic,Qualifier:Vector,CoordinateSystemName:DSRF,CoordinateRepresentation:Cartesian"

# Frame-specific vector attributes
Expand Down Expand Up @@ -99,6 +100,7 @@ magnitude:
UNITS: nT
VALIDMIN: 0
VALIDMAX: 1.0e+5
CDF_DATA_TYPE: CDF_FLOAT
DICT_KEY: SPASE>Field>FieldQuantity:Magnetic,Qualifier:Scalar

range:
Expand All @@ -111,6 +113,7 @@ range:
UNITS: ' '
VALIDMAX: 3
VALIDMIN: 0
CDF_DATA_TYPE: CDF_UINT1
DICT_KEY: SPASE>Support>SupportQuantity:InstrumentMode

pri_sens:
Expand Down
12 changes: 9 additions & 3 deletions imap_processing/mag/l2/mag_l2_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ def generate_dataset(
self.vectors,
name="vectors",
dims=["epoch", "direction"],
attrs=attribute_manager.get_variable_attributes(vector_attrs_name),
attrs=attribute_manager.get_variable_attributes(
vector_attrs_name, check_schema=False
),
)

quality_flags = xr.DataArray(
Expand All @@ -171,14 +173,18 @@ def generate_dataset(
self.range,
name="range",
dims=["epoch"],
attrs=attribute_manager.get_variable_attributes("range"),
attrs=attribute_manager.get_variable_attributes(
"range", check_schema=False
),
)

magnitude = xr.DataArray(
self.magnitude,
name="magnitude",
dims=["epoch"],
attrs=attribute_manager.get_variable_attributes("magnitude"),
attrs=attribute_manager.get_variable_attributes(
"magnitude", check_schema=False
),
)

global_attributes = (
Expand Down
1 change: 1 addition & 0 deletions imap_processing/tests/mag/test_mag_l2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def test_mag_l2_attributes(norm_dataset, mag_test_l2_data, data_mode):
assert dataset["range"].attrs["DICT_KEY"] == (
"SPASE>Support>SupportQuantity:InstrumentMode"
)
assert dataset["vectors"].attrs["CDF_DATA_TYPE"] == "CDF_FLOAT"


def test_mag_l2(norm_dataset, mag_test_l2_data):
Expand Down