feat: Concurrent executions with indexedDB Main Finalization #1328

atomicgamedeveloper · 2025-09-19T20:54:00Z

Pull Request Template

Title

Finalize Implementation of Concurrent Digital Twin Execution with IndexedDB Integration

Type of Change

Description

This PR finalizes the implementation of the concurrent execution for Digital Twins with IndexedDB integration. Users can now start multiple executions of the same Digital Twin simultaneously, with execution history persisted in the browser's IndexedDB. The implementation includes a new execution history data model, IndexedDB service, and UI components to display and manage execution history.

New is that it merges recent changes of the up-coming version 0.8 of DTaaS such as settings menu and new interface design.

Working on Testing

Added unit tests for the IndexedDB service and Redux store
Manually tested concurrent execution functionality
Verified persistence of execution history across browser sessions
Fixed existing tests to accommodate the new functionality

Impact

Improves user experience by allowing multiple executions to run in parallel
Adds local persistence of execution history using IndexedDB
Enhances the UI with execution history list and status indicators

Additional Information

This PR builds on top of #1235 by Microchesst.

Checklist

My code adheres to the coding and style guidelines of the project.
I have added tests for all the new code and any changes made to existing code.
I have made corresponding changes to the documentation.

…sting.

…rchitecture.

codecov · 2025-09-19T21:02:46Z

Codecov Report

❌ Patch coverage is 83.64905% with 164 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.05%. Comparing base (6802dbd) to head (3049e79).

Files with missing lines	Patch %	Lines
...del/backend/gitlab/state/executionHistory.slice.ts	73.33%	36 Missing ⚠️
client/src/services/ExecutionStatusService.ts	13.15%	33 Missing ⚠️
client/src/database/digitalTwins.ts	84.00%	20 Missing ⚠️
...e/digitaltwins/execution/executionStatusManager.ts	77.21%	18 Missing ⚠️
.../digitaltwins/execution/executionStatusHandlers.ts	71.18%	17 Missing ⚠️
.../src/model/backend/gitlab/execution/logFetching.ts	71.05%	11 Missing ⚠️
client/src/model/backend/LogDialog.tsx	78.37%	8 Missing ⚠️
.../src/components/execution/ExecutionHistoryList.tsx	93.69%	7 Missing ⚠️
client/src/model/backend/digitalTwin.ts	91.80%	5 Missing ⚠️
...preview/route/digitaltwins/manage/DeleteDialog.tsx	87.50%	2 Missing ⚠️
... and 6 more

Additional details and impacted files

@@                     Coverage Diff                      @@
##           feature/distributed-demo    #1328      +/-   ##
============================================================
- Coverage                     95.72%   88.05%   -7.67%     
============================================================
  Files                           103      128      +25     
  Lines                          2875     3734     +859     
  Branches                        483      604     +121     
============================================================
+ Hits                           2752     3288     +536     
- Misses                          120      443     +323     
  Partials                          3        3

Files with missing lines	Coverage Δ
client/src/components/asset/HistoryButton.tsx	`100.00% <100.00%> (ø)`
client/src/database/types.ts	`100.00% <100.00%> (ø)`
client/src/model/backend/DTAssets.ts	`76.76% <ø> (ø)`
client/src/model/backend/fileHandler.ts	`91.02% <ø> (ø)`
...odel/backend/gitlab/digitalTwinConfig/constants.ts	`100.00% <100.00%> (ø)`
...c/model/backend/gitlab/execution/statusChecking.ts	`100.00% <100.00%> (ø)`
...rc/model/backend/gitlab/state/digitalTwin.slice.ts	`100.00% <ø> (ø)`
...t/src/model/backend/interfaces/sharedInterfaces.ts	`100.00% <ø> (ø)`
client/src/model/backend/libraryAsset.ts	`95.74% <100.00%> (ø)`
client/src/model/backend/libraryManager.ts	`100.00% <ø> (ø)`
... and 38 more

... and 15 files with indirect coverage changes

Components	Coverage Δ
Website	`92.08% <83.64%> (-3.64%)`	⬇️
Lib Microservice	`2.95% <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2025-10-08T17:37:41Z

Quality Gate failed

Failed conditions
4.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copilot

Pull Request Overview

Finalizes the implementation of concurrent Digital Twin execution with IndexedDB integration for local persistence. Users can now start multiple executions simultaneously, view execution history, and manage executions through new UI components. This builds on version 0.8 changes including settings menu and interface design updates.

Key Changes

Adds IndexedDB service for execution history persistence
Implements concurrent execution support with execution status tracking
Adds new execution history UI components with log viewing capabilities

Reviewed Changes

Copilot reviewed 120 out of 125 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
servers/lib/test/integration/files.service.integration.spec.ts	Removes afterEach hook to fix test configuration
client/test/unit/route/digitaltwins/execution/ExecutionUIHandlers.test.ts	Adds comprehensive tests for execution UI handlers
client/test/unit/route/digitaltwins/execution/ExecutionStatusManager.test.ts	Updates import paths and adds type safety improvements
client/test/unit/route/digitaltwins/execution/ExecutionButtonHandlers.test.ts	Updates imports and adds execution ID parameter support
client/test/unit/model/backend/gitlab/execution/statusChecking.test.ts	Comments out null/undefined parameter tests
client/test/unit/model/backend/gitlab/execution/logFetching.test.ts	Removes null project ID test case
client/test/unit/database/digitalTwins.test.ts	Adds comprehensive IndexedDB service tests
client/test/unit/components/PrivateRoute.test.tsx	Adds mocks for new execution history components
client/test/preview/unit/util/*.test.ts	Updates import paths from preview/util to model/backend
client/test/unit/components/execution/ExecutionHistoryList.test.tsx	Adds comprehensive tests for execution history UI component
client/test/unit/components/asset/*.test.tsx	Updates component tests for new execution history functionality
client/test/preview/unit/store/executionHistory.slice.test.ts	Adds comprehensive Redux slice tests
client/test/preview/unit/store/Store.test.ts	Updates for new Redux state structure
client/test/preview/unit/routes/digitaltwins/manage/*.test.tsx	Updates for new adapter pattern
client/test/preview/unit/routes/digitaltwins/execute/*.test.tsx	Updates imports and adds execution history tests
client/test/preview/integration/*/.test.tsx	Updates integration tests for new execution patterns
client/test/e2e/tests/*.test.ts	Adds end-to-end tests for concurrent execution
client/src/util/digitalTwinAdapter.ts	Adds adapter pattern for bridging Redux state and business logic
client/src/store/store.ts	Adds execution history slice to Redux store
client/src/store/snackbar.slice.ts	Simplifies snackbar hide logic
client/src/store/selectors/*.ts	Adds selectors for execution history and digital twin state
client/src/route/digitaltwins/Snackbar.tsx	Updates import path for snackbar slice
client/src/preview/store/cart.slice.ts	Updates import path for LibraryAsset

Comments suppressed due to low confidence (2)

servers/lib/test/integration/files.service.integration.spec.ts:1

The removal of afterEach hook may cause test isolation issues if mocks are not properly reset between tests. Consider adding this back or ensuring mock cleanup is handled elsewhere.

import { describe, it, expect, jest } from '@jest/globals';

client/test/unit/model/backend/gitlab/execution/logFetching.test.ts:1

Removing the null projectId test case reduces coverage for error handling scenarios. This test case helps ensure the function gracefully handles missing project IDs.

import {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-10T16:51:43Z

client/src/store/store.ts

+        ignoredActions: [
+          'digitalTwin/setDigitalTwin',
+          'assets/setAsset',
+          'assets/setAsset',


The 'assets/setAsset' action is duplicated in the ignoredActions array. Remove the duplicate entry.

Suggested change

'assets/setAsset',

Copilot · 2025-10-10T16:51:43Z

client/test/unit/database/digitalTwins.test.ts

+
+if (typeof globalThis.structuredClone !== 'function') {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  globalThis.structuredClone = (obj: any): any =>
+    JSON.parse(JSON.stringify(obj));
+}
+


The structuredClone polyfill implementation may not handle all edge cases that the native implementation does (e.g., circular references, complex objects). Consider using a more robust polyfill library or documenting the limitations.

Suggested change

if (typeof globalThis.structuredClone !== 'function') {

// eslint-disable-next-line @typescript-eslint/no-explicit-any

globalThis.structuredClone = (obj: any): any =>

JSON.parse(JSON.stringify(obj));

}

import structuredClonePolyfill from '@ungap/structured-clone';

if (typeof globalThis.structuredClone !== 'function') {

globalThis.structuredClone = structuredClonePolyfill;

}

prasadtalasila · 2025-10-12T06:28:26Z

@atomicgamedeveloper please add the following lines at the end of .gitignore file (this file exists at the top-level of the project)


.qlty
!.qlty/qlty.toml

prasadtalasila

@atomicgamedeveloper thanks for the huge PR. Please see the comments. General suggestions.

Please remove relative paths in imports.
Where possible, move code to model/. For example, new code added in util can probably go into model/util.

thanks

prasadtalasila · 2025-10-10T14:33:06Z

client/src/preview/util/digitalTwinUtils.ts

This file can be moved out of preview/...

prasadtalasila · 2025-10-10T14:41:26Z

client/src/model/backend/LogDialog.tsx

please move the react components to src/components/...

prasadtalasila · 2025-10-10T14:49:57Z

client/src/route/digitaltwins/Snackbar.tsx

you mentioned about SnackBar component being used in other pages. Can this component be moved to src/components/?

prasadtalasila · 2025-10-10T14:54:14Z

client/src/model/backend/gitlab/execution/statusChecking.ts

    case 'success':
-      executionStatus = ExecutionStatus.COMPLETED;
-      break;
+      return ExecutionStatus.COMPLETED;


This change would give linting error of too many return statements.

prasadtalasila · 2025-10-10T14:54:49Z

client/src/model/backend/gitlab/execution/statusChecking.ts

-    }
+export const getStatusDescription = (status: string): string => {
+  switch (status.toLowerCase()) {
+    case 'success':


Is there a way to avoid too many return statements?

prasadtalasila · 2025-10-12T06:18:44Z

client/src/database/digitalTwins.ts

+ * Interface for execution history operations
+ * Abstracts away the underlying storage implementation
+ */
+export interface IExecutionHistory {


Can this interface be moved to model/backend/interfaces/execution.ts?

prasadtalasila · 2025-10-12T06:21:39Z

client/src/database/types.ts

+/**
+ * Represents the schema for the IndexedDB database
+ */
+export interface IndexedDBSchema {


this does not seem to have been used anywhere.

prasadtalasila · 2025-10-12T06:42:09Z

client/src/util/digitalTwinAdapter.ts

@@ -0,0 +1,59 @@
+import DigitalTwin from 'model/backend/digitalTwin';
+import { DigitalTwinData } from 'model/backend/gitlab/state/digitalTwin.slice';
+import { initDigitalTwin } from 'preview/util/init';


please remove the dependency to preview code. Also this code can be placed in model/util directory.

prasadtalasila · 2025-10-12T06:43:50Z

client/src/store/selectors/executionHistory.selectors.ts

can this go into model/backend/state?

prasadtalasila · 2025-10-12T06:46:59Z

client/src/util/digitalTwinAdapter.ts

this can probably go into model/util/

prasadtalasila · 2025-10-12T07:06:35Z

This PR resolves issue #1232 and #1314

Microchesst and others added 16 commits May 1, 2025 20:50

feat: Concurrent executions with indexedDB

26e5724

yarn syntax

e168a9a

test: everything except e2e

6fc0304

yarn format

117405f

e2e Test

a8a6614

test: e2e

047f00d

feat: now using accordion and can load across reloads, still needs te…

b91218f

…sting.

Feat: interface for 'database/digitaltTwins.ts'

58f6d06

fix: now only updating a dt's specific state

c80a929

fix: moving some files out of preview code

9d3f7e3

test: unit int and e2e are now updated.

4e522fe

feat: refactoring to keep code structure, and to define a good code a…

1c0f14c

…rchitecture.

Steady e2e tests

7ff06cf

Merge branch 'conc-branch'

2c410b8

Fix (preview) unit/int import errors

c7625b3

Fix remaining tests

5372c1e

atomicgamedeveloper added 4 commits September 29, 2025 16:40

Address review comments

70a9d39

Verify Previous Changes Present

b438465

Mv files for PR INTO-CPS-Association#1314

7c8b331

Deduplicate code in tests

3049e79

prasadtalasila requested a review from Copilot October 10, 2025 16:50

Copilot AI reviewed Oct 10, 2025

View reviewed changes

prasadtalasila reviewed Oct 12, 2025

View reviewed changes

prasadtalasila added this to Digital Twin as a Service Oct 12, 2025

prasadtalasila added this to the Release v0.8 milestone Oct 12, 2025

prasadtalasila moved this to In progress in Digital Twin as a Service Oct 12, 2025

feat: Concurrent executions with indexedDB Main Finalization #1328

Are you sure you want to change the base?

feat: Concurrent executions with indexedDB Main Finalization #1328

Uh oh!

Conversation

atomicgamedeveloper commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Template

Title

Type of Change

Description

Working on Testing

Impact

Additional Information

Checklist

Uh oh!

codecov bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud bot commented Oct 8, 2025

Quality Gate failed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

prasadtalasila commented Oct 12, 2025

Uh oh!

prasadtalasila left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prasadtalasila commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

atomicgamedeveloper commented Sep 19, 2025 •

edited

Loading

codecov bot commented Sep 19, 2025 •

edited

Loading