Model field reference edit pre poulated selections#217
Open
stephguac wants to merge 9 commits intoISBX:masterfrom
Open
Model field reference edit pre poulated selections#217stephguac wants to merge 9 commits intoISBX:masterfrom
stephguac wants to merge 9 commits intoISBX:masterfrom
Conversation
tma-isbx
reviewed
Aug 24, 2017
|
|
||
| function removeSelectedFromList(selected, list, id) { | ||
| var filteredList = _.reject(list, function(o) { | ||
| for (var i = 0; i < selected.length; i++) { |
Contributor
There was a problem hiding this comment.
Maybe we can use _.find() here instead?
tma-isbx
reviewed
Aug 24, 2017
| GeneralModelService.list(apiPath, params, {preventCancel: true}).then(function(response) { | ||
| if (!response) return; //in case http request was cancelled by newer request | ||
| scope.list = response; | ||
| scope.list = scope.selected.items ? removeSelectedFromList(scope.selected.items, response, scope.options.key) : response; |
Contributor
There was a problem hiding this comment.
Do we need the branch? Can we just always do:
scope.list = removeSelectedFromlist()?
added 3 commits
August 25, 2017 14:55
…ttps://github.com/stephguac/isbx-loopback-cms into model-field-reference-edit-pre-poulated-selections
tma-isbx
reviewed
Aug 26, 2017
| }); | ||
|
|
||
| scope.$watch('selected.items', function() { // watch selected.items to ensure previously selected items are accounted for. | ||
| if (scope.selected && scope.selected.items && scope.selected.items.length) { |
Contributor
There was a problem hiding this comment.
We shouldn't check length here, otherwise removing the last selected item will not refreshChoices, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tma-isbx