Merged
Conversation
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
4 times, most recently
from
bad8439 to
903a140
Compare
yhabteab
force-pushed
the
restructure-codes
branch
4 times, most recently
from
371636c to
6bddc85
Compare
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
903a140 to
b5bcddf
Compare
julianbrost
reviewed
May 22, 2023
Member
julianbrost
left a comment
julianbrost
left a comment
There was a problem hiding this comment.
First few comments only, i.e. those until I noticed that I should probably look at #67 first.
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
b5bcddf to
8e29178
Compare
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
8e29178 to
fcfb235
Compare
yhabteab
force-pushed
the
use-sqlx-tx
branch
2 times, most recently
from
72f0f89 to
c48835b
Compare
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
2 times, most recently
from
9150312 to
fcfb235
Compare
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
fcfb235 to
bee18d4
Compare
yhabteab
force-pushed
the
use-sqlx-tx
branch
2 times, most recently
from
3d14c51 to
f44c4b6
Compare
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
bee18d4 to
f2cb44c
Compare
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
f2cb44c to
f62d32b
Compare
yhabteab
force-pushed
the
use-sqlx-tx
branch
2 times, most recently
from
115a60a to
24b6dd0
Compare
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
f62d32b to
14f0014
Compare
julianbrost
reviewed
Aug 10, 2023
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
2 times, most recently
from
2f967f3 to
ea9166d
Compare
julianbrost
requested changes
Nov 8, 2023
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
ea9166d to
fd54f6f
Compare
julianbrost
requested changes
Nov 9, 2023
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
2 times, most recently
from
a08d873 to
28ad757
Compare
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
28ad757 to
d127963
Compare
julianbrost
reviewed
Nov 15, 2023
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
d127963 to
1b8b219
Compare
julianbrost
requested changes
Nov 16, 2023
Co-Authored-By: Julian Brost <julian.brost@icinga.com>
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
1b8b219 to
bc6536e
Compare
Co-authored-by: Yonas Habteab <yonas.habteab@icinga.com>
yhabteab
force-pushed
the
trigger-time-based-escalations
branch
from
bc6536e to
bbb9edc
Compare
julianbrost
requested changes
Nov 16, 2023
Member
julianbrost
left a comment
julianbrost
left a comment
There was a problem hiding this comment.
One message in the event is incorrect. Apart from that, this PR should be good to go.
Otherwise, the notification subject is looking odd, since this field is used to build the notification messages.
julianbrost
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #63