Merged
Conversation
oxzi
added a commit
to Icinga/icingadb
that referenced
this pull request
Jan 15, 2026
Add a new DowntimeRemovedCheckable sub-test to check if Downtime objects on disappearing objects are being properly closed. This might happen for Director deployments, using config packages, as these tests do. Requires Icinga/icinga-testing#34
oxzi
force-pushed
the
config-package-support
branch
from
9db2e59 to
95b389a
Compare
julianbrost
approved these changes
Jan 20, 2026
Member
julianbrost
left a comment
julianbrost
left a comment
There was a problem hiding this comment.
Looks sane. And after all, it's test code, so what's the worst that could happen? :)
Implement just enough to create config packages and new stages. This became a requirement for testing in Icinga DB.
oxzi
force-pushed
the
config-package-support
branch
from
95b389a to
6dde607
Compare
oxzi
added a commit
to Icinga/icingadb
that referenced
this pull request
Jan 20, 2026
Config Packages are required in the integration tests to interact with disappearing objects. Icinga/icinga-testing#34
oxzi
added a commit
to Icinga/icingadb
that referenced
this pull request
Jan 22, 2026
oxzi
added a commit
to Icinga/icingadb
that referenced
this pull request
Jan 27, 2026
oxzi
added a commit
to Icinga/icingadb
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement just enough to create config packages and new stages.
This became a requirement for testing in Icinga DB.
Required for tests for Icinga/icingadb#913