Skip to content

fix(date-editor): Use default display format based on locale. #16237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: skrastev/localization
Choose a base branch
from
Open

fix(date-editor): Use default display format based on locale. #16237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8590a10
fix(date-editor): Use default display format based on locale.
Sep 23, 2025
823d44f
chore(*): Replace angular's format date with the new core lib one.
Sep 24, 2025
ea41d72
chore(*): Use default locale from core when resolving default input f…
Sep 24, 2025
2961c92
chore(*): Pass specific input options to intl formatter in core.
Sep 24, 2025
f3fb8ec
chore(*): Remove unused functions in util.
Sep 24, 2025
8a5c1f6
chore(*): Pass format options based on dataType.
Sep 24, 2025
bb218ff
chore(*): Update formats in tests to match Intl.
Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions projects/igniteui-angular/src/lib/date-common/util/date-time.util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { DatePart, DatePartInfo } from '../../directives/date-time-editor/date-time-editor.common';
import { formatDate, FormatWidth, getLocaleDateFormat } from '@angular/common';
import { formatDate } from '@angular/common';
import { ValidationErrors } from '@angular/forms';
import { isDate } from '../../core/utils';
import { getLocaleDateFormat, isDate } from '../../core/utils';
import { DataType } from '../../data-operations/data-util';

/** @hidden */
Expand Down Expand Up @@ -283,22 +283,7 @@ export abstract class DateTimeUtil {
* Supports Angular's DatePipe format options such as `shortDate`, `longDate`.
*/
public static getLocaleDateFormat(locale: string, displayFormat?: string): string {
Copy link
Member

@skrustev skrustev Sep 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also a few methods using Intl.DateTimeFormat that can be replaced to use the new date formatters from igniteui-i18n-core. For example formatDate(should use the util.js format date instead), getDefaultInputFormat, getLocaleInputFormatFromParts and methods that use them maybe as well.

const formatKeys = Object.keys(FormatWidth) as (keyof FormatWidth)[];
const targetKey = formatKeys.find(k => k.toLowerCase() === displayFormat?.toLowerCase().replace('date', ''));
if (!targetKey) {
// if displayFormat is not shortDate, longDate, etc.
// or if it is not set by the user
return displayFormat;
}
let format: string;
try {
format = getLocaleDateFormat(locale, FormatWidth[targetKey]);
} catch {
DateTimeUtil.logMissingLocaleSettings(locale);
format = DateTimeUtil.getDefaultInputFormat(locale);
}

return format;
return getLocaleDateFormat(locale, displayFormat);
}

/** Determines if a given character is `d/M/y` or `h/m/s`. */
Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
}

public get displayFormat(): string {
return this._displayFormat || this.inputFormat;
return this._displayFormat || this._inputFormat || DateTimeUtil.getLocaleDateFormat(this.locale, 'short');
}

/**
Expand Down