chore(*): Get dom elements on demand after load. #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Issue 1: When running all the samples, going to pivot-grid/data-persistence-noop sample error message is shown in console 
|
Contributor
|
Issue 2: When running all the samples, going to pivot-grid/state-persistence-main sample and clicking on "Restore" error messages are shown in console 
|
Contributor
Author
|
@MarielaTihova Fix is already pushed.
|
Contributor
|
Issue 3: Lots of warnings are thrown in the console when running all samples |
Contributor
Marking PR as verified, as this is related to unexpected user behaviour and is a minor issue. |
MarielaTihova
added
status: verified
Contributor
Issue is already resolved in another PR |
Contributor
Author
@MarielaTihova Sure. But I was unable to reproduce it with the provided steps. Could you re-check if this still reproduces for you? If so could you provide more details, such as what state is being restored for the grid? |
Contributor
|
All issues are either resolved or can't reproduce anymore. |
dkamburov
approved these changes
Sep 30, 2024
HUSSAR-mtrela
added a commit
that referenced
this pull request
Dec 27, 2024
* feat(carousel): add samples * Adding changes from build igniteui-xplat-examples-output+PRs_2024.9.13.1 (#846) * Renaming the sample so it doesn't cause build error (#847) Co-authored-by: Ivan Kitanov <[email protected]> * chore(*): Get dom elements on demand after load. (#835) * fix(#848): Resolved unresponsiveness on hiding a maximized pane. (#849) Co-authored-by: igdmdimitrov <[email protected]> * chore(*): update to 5.0.0-beta.0 (#851) * chore(*): update ig packages to 5.0.2 (#852) * Fixes to samples and some improvements (#843) * Adding changes from build igniteui-xplat-examples-output+PRs_2024.10.21.1 (#854) Co-authored-by: tfsbuild <[email protected]> * fix(carousel): change properties' names; update lit and ig versions * fix(carousel): add animation type to thumbnail sample * Edited data shown for consistency with other platforms * Update web components package to 5.1.1 (#859) * Unify range slider styling sample between platforms. (#691) * fix(grid): fixed grid overlay scroll in pop up containers (#861) * fix(*): add constructor; add minor style changes * chore(*): update ig packages to 5.0.3-beta.0 (#865) * Re-instate steps for Licensed packages & use npm install npm install instead of npm ci - due to some package balagans * Re-instate licensed packages & use node 18 (#866) * chore(deps): bump follow-redirects from 1.15.4 to 1.15.9 Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.9. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.9) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.11.14.1 (#873) * chore(deps-dev): bump express from 4.18.2 to 4.21.1 Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.21.1. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md) - [Commits](expressjs/express@4.18.2...4.21.1) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps-dev): bump webpack from 5.89.0 to 5.96.1 Bumps [webpack](https://github.com/webpack/webpack) from 5.89.0 to 5.96.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.89.0...v5.96.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Bump webpack-dev-middleware from 5.3.3 to 5.3.4 Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(*): update ig packages to 5.1.0 (#878) * update readme * readme - Updating Packages in Samples * revert CodeOwners * caching issues (#883) * mdd-update-browser-5.1.1-beta.0 (#885) mdd-update-browser-5.1.1-beta.0 * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.13.3 * update update * update packages to 5.1.1-beta.1 * update package-lock * mdd-update-with-dashboards (#900) mdd-update-with-dashboards * update to next beta packages (#909) * update to next beta packages * update locak file * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.17.7 (#911) Co-authored-by: tfsbuild <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.18.1 (#912) Co-authored-by: tfsbuild <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.18.2 (#913) Co-authored-by: tfsbuild <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.18.3 (#914) Co-authored-by: tfsbuild <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.18.4 (#915) Co-authored-by: tfsbuild <[email protected]> * update packages for 24.2 release (#916) * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.19.3 (#917) Co-authored-by: tfsbuild <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: RivaIvanova <[email protected]> Co-authored-by: azure-pipelines[bot] <36771401+azure-pipelines[bot]@users.noreply.github.com> Co-authored-by: Ivan Kitanov <[email protected]> Co-authored-by: Ivan Kitanov <[email protected]> Co-authored-by: Maya <[email protected]> Co-authored-by: Galina Edinakova <[email protected]> Co-authored-by: igdmdimitrov <[email protected]> Co-authored-by: Deyan Kamburov <[email protected]> Co-authored-by: Svetoslav Krastev <[email protected]> Co-authored-by: Riva Ivanova <[email protected]> Co-authored-by: tfsbuild <[email protected]> Co-authored-by: Mariela Tihova <[email protected]> Co-authored-by: Vasya Kacheshmarova <[email protected]> Co-authored-by: Tihomir Tonev <[email protected]> Co-authored-by: Borislav Traykov <[email protected]> Co-authored-by: Konstantin Dinev <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Deyan Kamburov <[email protected]> Co-authored-by: gmurray81 <[email protected]> Co-authored-by: mddifilippo89 <[email protected]> Co-authored-by: Valerie Suszynski <[email protected]>
HUSSAR-mtrela
added a commit
that referenced
this pull request
Mar 5, 2025
* feat(carousel): add samples * Adding changes from build igniteui-xplat-examples-output+PRs_2024.9.13.1 (#846) * Renaming the sample so it doesn't cause build error (#847) Co-authored-by: Ivan Kitanov <[email protected]> * chore(*): Get dom elements on demand after load. (#835) * fix(#848): Resolved unresponsiveness on hiding a maximized pane. (#849) Co-authored-by: igdmdimitrov <[email protected]> * chore(*): update to 5.0.0-beta.0 (#851) * chore(*): update ig packages to 5.0.2 (#852) * Fixes to samples and some improvements (#843) * Adding changes from build igniteui-xplat-examples-output+PRs_2024.10.21.1 (#854) Co-authored-by: tfsbuild <[email protected]> * fix(carousel): change properties' names; update lit and ig versions * fix(carousel): add animation type to thumbnail sample * Edited data shown for consistency with other platforms * Update web components package to 5.1.1 (#859) * Unify range slider styling sample between platforms. (#691) * fix(grid): fixed grid overlay scroll in pop up containers (#861) * fix(*): add constructor; add minor style changes * chore(*): update ig packages to 5.0.3-beta.0 (#865) * Re-instate steps for Licensed packages & use npm install npm install instead of npm ci - due to some package balagans * Re-instate licensed packages & use node 18 (#866) * chore(deps): bump follow-redirects from 1.15.4 to 1.15.9 Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.9. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.9) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.11.14.1 (#873) * chore(deps-dev): bump express from 4.18.2 to 4.21.1 Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.21.1. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md) - [Commits](expressjs/express@4.18.2...4.21.1) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps-dev): bump webpack from 5.89.0 to 5.96.1 Bumps [webpack](https://github.com/webpack/webpack) from 5.89.0 to 5.96.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.89.0...v5.96.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> * Bump webpack-dev-middleware from 5.3.3 to 5.3.4 Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(*): update ig packages to 5.1.0 (#878) * update readme * readme - Updating Packages in Samples * revert CodeOwners * caching issues (#883) * mdd-update-browser-5.1.1-beta.0 (#885) mdd-update-browser-5.1.1-beta.0 * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.13.3 * update update * update packages to 5.1.1-beta.1 * update package-lock * mdd-update-with-dashboards (#900) mdd-update-with-dashboards * update to next beta packages (#909) * update to next beta packages * update locak file * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.17.7 (#911) Co-authored-by: tfsbuild <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.18.1 (#912) Co-authored-by: tfsbuild <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.18.2 (#913) Co-authored-by: tfsbuild <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.18.3 (#914) Co-authored-by: tfsbuild <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.18.4 (#915) Co-authored-by: tfsbuild <[email protected]> * update packages for 24.2 release (#916) * Adding changes from build igniteui-xplat-examples-output+PRs_2024.12.19.3 (#917) Co-authored-by: tfsbuild <[email protected]> * added grid toolbar sample with dynamic features (#746) * Adding changes from build igniteui-xplat-examples-output+PRs_2025.1.22.1 (#919) * chore(*): update ig to 5.2.0-beta.0 (#921) * Update wc package version to latest SR 5.2.1 (#922) * chore(*): update ig packages to 5.2.0 (#923) * update css (#925) update css * feat(dock-manager): add split pane fixed size sample (#882) * feat(dock-manager): add split pane fixed size sample * chore(*): Update to 1.16.0 * fix(DockManager): Add an empty floating panes array to the layouts --------- Co-authored-by: Galina Edinakova <[email protected]> * Remote Paging Grid & Hgrid: Refactoring with the new customers endpoint (#874) * Adding changes from build igniteui-xplat-examples-output+PRs_2025.2.8.2 * Update samples to v5.2.1-beta.0. Related fixes for samples to work. (#938) * Add disabled summaries samples * Correct samples names and versions * Adding changes from build igniteui-xplat-examples-output+PRs_2025.2.21.1 * Adding changes from build igniteui-xplat-examples-output+PRs_2025.2.26.1 (#948) Co-authored-by: tfsbuild <[email protected]> * Merge pull request #940 from IgniteUI/apetrov/add-tile-manager-samples-vnext feat(tile-manager): add tile manager samples for wc * Adding changes from build igniteui-xplat-examples-output+PRs_2025.2.26.2 (#949) Co-authored-by: tfsbuild <[email protected]> Co-authored-by: mddifilippo89 <[email protected]> * Adding changes from build igniteui-xplat-examples-output+PRs_2025.2.28.1 * Revert "Merge pull request #940 from IgniteUI/apetrov/add-tile-manager-sample…" This reverts commit 58a6ba3. * update packages to use product build for 02/2025 SR * Update the versions of the samples --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: RivaIvanova <[email protected]> Co-authored-by: azure-pipelines[bot] <36771401+azure-pipelines[bot]@users.noreply.github.com> Co-authored-by: Ivan Kitanov <[email protected]> Co-authored-by: Ivan Kitanov <[email protected]> Co-authored-by: Maya <[email protected]> Co-authored-by: Galina Edinakova <[email protected]> Co-authored-by: igdmdimitrov <[email protected]> Co-authored-by: Deyan Kamburov <[email protected]> Co-authored-by: Svetoslav Krastev <[email protected]> Co-authored-by: Riva Ivanova <[email protected]> Co-authored-by: tfsbuild <[email protected]> Co-authored-by: Mariela Tihova <[email protected]> Co-authored-by: Vasya Kacheshmarova <[email protected]> Co-authored-by: Tihomir Tonev <[email protected]> Co-authored-by: Borislav Traykov <[email protected]> Co-authored-by: Konstantin Dinev <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Deyan Kamburov <[email protected]> Co-authored-by: gmurray81 <[email protected]> Co-authored-by: mddifilippo89 <[email protected]> Co-authored-by: Valerie Suszynski <[email protected]> Co-authored-by: Georgi Anastasov <[email protected]> Co-authored-by: Adrian Petrov <[email protected]> Co-authored-by: Stamen Stoychev <[email protected]> Co-authored-by: Georgi Anastasov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #834