Skip to content

Fixes to samples and some improvements #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Fixes to samples and some improvements #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d1aa0a
Fix list sample initial radio being checked. #839
skrustev Sep 9, 2024
360b8c0
Add default separator for clipboard operations sample.
skrustev Sep 9, 2024
6de1f71
Match avatar size sample with other platform samples.
skrustev Sep 9, 2024
dd84362
Add default separator for tree grid clipboard operations sample as well.
skrustev Sep 10, 2024
57858c4
Tweak clipboard operation samples so they work standalone.
skrustev Sep 13, 2024
60e5dff
Merge branch 'vnext' into skrastev/fix-samples
dkamburov Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions samples/grids/grid/clipboard-operations/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ defineAllComponents();
import "./index.css";

export class Sample {
private defaultSeparator: string;
private grid: IgcGridComponent
private _bind: () => void;

Expand Down Expand Up @@ -44,7 +45,10 @@ export class Sample {

var input = document.getElementById("input") as IgcInputComponent;
input.addEventListener("igcChange", (ev: CustomEvent) => {
grid.clipboardOptions.separator = ev.detail;
if (!this.defaultSeparator) {
this.defaultSeparator = grid.clipboardOptions.separator;
}
grid.clipboardOptions.separator = ev.detail || this.defaultSeparator;
});
}
this._bind();
Expand All @@ -65,7 +69,6 @@ export class Sample {
column.formatter = (e: any) => { return "** " + e + " **" };
column.header = "🎉" + column.field;
}

}

new Sample();
4 changes: 2 additions & 2 deletions samples/grids/list/overview/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
<div class="container sample center">
<igc-radio-group id="radio-group" alignment="horizontal" style="margin-bottom: 10px;">
<igc-radio name="size" value="small" label-position="after">Small</igc-radio>
<igc-radio name="size" value="medium" label-position="after">Medium</igc-radio>
<igc-radio name="size" value="large" label-position="after" checked>Large</igc-radio>
<igc-radio name="size" value="medium" label-position="after" checked >Medium</igc-radio>
<igc-radio name="size" value="large" label-position="after">Large</igc-radio>
</igc-radio-group>

<igc-list id="list">
Expand Down
6 changes: 5 additions & 1 deletion samples/grids/tree-grid/clipboard-operations/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export class Sample {
private clipboardHeadersEditor: IgcPropertyEditorPropertyDescriptionComponent
private clipboardFormattersEditor: IgcPropertyEditorPropertyDescriptionComponent
private treeGrid: IgcTreeGridComponent
private defaultSeparator: string;

constructor() {
var clipboardEnabledEditor = this.clipboardEnabledEditor = document.getElementById('ClipboardEnabledEditor') as IgcPropertyEditorPropertyDescriptionComponent;
Expand Down Expand Up @@ -51,7 +52,10 @@ export class Sample {

var input = document.getElementById("input") as IgcInputComponent;
input.addEventListener("igcChange", (ev: CustomEvent) => {
grid.clipboardOptions.separator = ev.detail;
if (!this.defaultSeparator) {
this.defaultSeparator = grid.clipboardOptions.separator;
}
grid.clipboardOptions.separator = ev.detail || this.defaultSeparator;
});
}

Expand Down
6 changes: 3 additions & 3 deletions samples/layouts/avatar/size/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
<body>
<div id="root">
<div class="container sample center">
<igc-avatar initials="AZ">
<igc-icon name="home" collection="material"></igc-icon>
</igc-avatar>
<igc-avatar class="size-large" initials="L"></igc-avatar>
<igc-avatar class="size-medium" initials="M"></igc-avatar>
<igc-avatar class="size-small" initials="S"></igc-avatar>
</div>
</div>

Expand Down
15 changes: 14 additions & 1 deletion samples/layouts/avatar/size/src/AvatarSize.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
igc-avatar {
.size-small {
--ig-size: var(--ig-size-small);
}

.size-medium {
--ig-size: var(--ig-size-medium);
}

.size-large {
--ig-size: var(--ig-size-large);
}

.sample {
flex-direction: row;
gap: 10px;
}
Loading