allegro5: take image region into account for NK_COMMAND_IMAGE #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took me a while to get it totally right, but everything is correct this time, I swear 😅 |
|
That's one nice looking button 👍 |
|
Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. This pull request makes allegro5 backend take the image region into account for
NK_COMMAND_IMAGEcommand. Without that, it is impossible to e.g. correctly render 9-slice, consider:before:
after:
I suspect similar problem is present in gdi, gdi_native, gdip, rawfb, x11 and x11_xft backends, but unfortunately I lack the knowledge nor time to fix those.